Multi tool select buttons bug

[JoseQuintas2003]

Description of Changes

Changes:

• In the multitool page, the behavior of the "Select/Deselect All" buttons was changed so that if no pages are selected, then the "Deselect All" button is disabled, and if all pages are selected, then the "Select All" button is disabled.
• These buttons will also appear if the "Page Select" is turned on, either by pressing the "Page Select" button or manually selecting one page.
• Furthermore, a bug that caused the pages to remain selected when "Page Select" is off was also fixed

Why the changes were made:

• The multitool did not allow the "Select All" or "Deselect All" button to appear simultaneously. The multitool was relying on a toggle mechanic for the Page Selection and this could prevent the user from selecting or deselecting all pages as intended, if they manually select/deselect one or more pages.

Other challenges:

• No particular challenges encountered

Relevant Screenshots:

Fig. 1 - Only "Select All" button appears when Page Select is turned on, since no pages are selected

Fig. 2 - Both "Select All" and "Deselect All" buttons appear when one or more, but not all pages are selected

Fig. 3 - Only "Deselect All" button appears when all pages are selected

Fig. 4 - When Page Select is turned off, both "Select All" and "Deselect All" buttons disappear and all pages are deselected

Closes #3206

---

Checklist

General

• I have read the Contribution Guidelines
• I have read the Stirling-PDF Developer Guide (if applicable)
• I have read the How to add new languages to Stirling-PDF (if applicable)
• I have performed a self-review of my own code
• My changes generate no new warnings

Documentation

• I have updated relevant docs on Stirling-PDF's doc repo (if functionality has heavily changed)
• I have read the section Add New Translation Tags (for new translation tags only)

UI Changes (if applicable)

• Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

• I have tested my changes locally. Refer to the Testing Guide for more details.

[Copilot]

Pull Request Overview

This PR addresses the multi tool select buttons bug by updating the behavior of the "Select All" and "Deselect All" buttons and fixing a bug where pages remained selected when the Page Select was turned off.

• Updated the button's onclick handlers in multi-tool.html to correctly trigger selection/deselection functions.
• Introduced and bound a new toggleDeselectAll method in PdfContainer.js while refactoring the selection logic.
• Modified updateSelectedPagesDisplay in PdfContainer.js to adjust button visibility based on current selection states.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/main/resources/templates/multi-tool.html	Changed onclick handler for the deselect button to call toggleDeselectAll.
src/main/resources/static/js/multitool/PdfContainer.js	Added toggleDeselectAll and refactored select/deselect logic and UI updates.

[ConnorYoh]

/deploypr

[stirlingbot]

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:3404
Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

[ConnorYoh]

Stirling-PDF.PR.3404.-.PDF.Multi.Tool.-.Google.Chrome.2025-04-23.13-29-22.mp4

Hi @JoseQuintas2003, Looks like some great progress. In the video above you can see that the selectall button remains present after turning off selected pages. Would you be able to correct this?

Also:

Stirling-PDF.PR.3404.-.PDF.Multi.Tool.-.Google.Chrome.2025-04-23.13-38-38.mp4

It looks like after you move some pages the deselectAll button never reappears. Would you be able to look into this?

[JoseQuintas2003]

Hey there, great to receive some feedback on my work so far. I'm surprised I didn't notice these bugs, but I suppose it's normal some things might have gone unnoticed. I'll begin making the corrections asap. Thank you for your detailed feedback.

[JoseQuintas2003]

Hey there once more @ConnorYoh. I believe I have solved the problems you mentioned in these 3 commits. I hope nothing has escaped me this time, but if there's anything I can help with or improve, then just let me know. Talk to you soon!

[ConnorYoh]

/deploypr

[stirlingbot]

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:3404
Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

[ConnorYoh]

Hi @JoseQuintas2003 Thanks for the changes, looks like you have fixed the bugs however the selectAll button is no longer functioning. I believe its because window.selectAll is defined twice, once as a function and once as a Boolean.(line 77 and set within the file multiple times but is never used) I think we can now remove the Boolean as you have replaced the need for it.

Stirling-PDF.PR.3404.-.PDF.Multi.Tool.-.Google.Chrome.2025-04-24.10-10-44.mp4

[JoseQuintas2003]

Hey there @ConnorYoh. So sorry I missed that. It seems its a simple solution as you suggested, I'll take care of it.

[JoseQuintas2003]

@ConnorYoh its done. Hopefully this clears everything. Thanks for the help. I apologize if this took longer than necessary.

[ConnorYoh]

/deploypr

[stirlingbot]

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:3404
Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

[ConnorYoh]

No Apologies necessary, thank you for your efforts and contributing it is really appreciated.