Skip to content

[Bug]: Multitool select/deselect all button not showing correctly #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
ConnorYoh opened this issue Mar 19, 2025 · 10 comments · May be fixed by #3404
Open
1 task done

[Bug]: Multitool select/deselect all button not showing correctly #3206

ConnorYoh opened this issue Mar 19, 2025 · 10 comments · May be fixed by #3404
Assignees
Labels
Bug Something isn't working Front End Issues or pull requests related to front-end development

Comments

@ConnorYoh
Copy link
Contributor

Installation Method

None

The Problem

In multitool:

  • Select all button should show after page select is enabled
  • Deselect all button should show after page select is enabled
  • Select all button should be disabled if all pages are selected
  • Deselect all button should be disabled if no pages are selected.

Add enabled/disabled colouring to page select button when pressed/depressed

Version of Stirling-PDF

0.44.2

Last Working Version of Stirling-PDF

No response

Page Where the Problem Occurred

No response

Docker Configuration

Relevant Log Output

Additional Information

No response

Browsers Affected

No response

No Duplicate of the Issue

  • I have verified that there are no existing issues raised related to my problem.
@dosubot dosubot bot added the Front End Issues or pull requests related to front-end development label Mar 19, 2025
@Frooodle Frooodle added the Bug Something isn't working label Mar 19, 2025
@JoseQuintas2003
Copy link

I would like to work on this issue. Could you assign this to me?

I would also like to clarify just one question regarding the bug:
Currently, only the "Select All" button appears when "page select" button is pressed or a page is selected.
Are the "Select All" and "Deselect All" buttons meant to be two distinct buttons that appear once "page selected" is pressed or a page is selected?

@ConnorYoh

@JoseQuintas2003
Copy link

Sorry, I should've mentioned @Frooodle as well

@ConnorYoh
Copy link
Contributor Author

Hi @JoseQuintas2003. Sorry I missed your comment there. Yes you are spot on, the buttons should appear once the page selection has begun. They should not be visible if page selection is not enabled.

Please let me know if you have any more questions.

@JoseQuintas2003
Copy link

Thank you so much for the clarification. I'll begin working on it asap. Have a nice day!

@ConnorYoh ConnorYoh moved this to In Progress in Stirling-PDF V1 Apr 9, 2025
@ConnorYoh
Copy link
Contributor Author

Hi @JoseQuintas2003, how are you getting on? Let me know if you want any assistance, clarification or just someone to bounce an idea off.

@JoseQuintas2003
Copy link

Hey there @ConnorYoh I believe I have already come up with the solution for this issue, but I did noticeone thing which I think I should discuss here before concluding the development.

The question is: If you press the "Page Select" button when there are one or more pages currently selected, these pages remain selected despite Page Selection being turned off. Should all pages be deselected when the Page Selection is turned off or is this behavior intentional? (Screenshot that might more easily demonstrate this below)

Pages still selected despite Page Selection being off

@ConnorYoh
Copy link
Contributor Author

Hi @JoseQuintas2003, great to hear you are having success with the issue!
Yes you are absolutely correct if page select is disabled using the button in the toolbar, all pages should be deselected. Great spot, would you be able to/have the time to correct the behaviour in the same PR? Thank you 😄

@JoseQuintas2003
Copy link

Yes, @ConnorYoh, I can handle it in the same PR. Since I'm already done with the issue itself, I'll work this part out now and I'll open the said PR then. Thanks for the help. Have a great day!

@JoseQuintas2003 JoseQuintas2003 linked a pull request Apr 23, 2025 that will close this issue
9 tasks
@JoseQuintas2003
Copy link

Hey there @ConnorYoh, I have just opened the PR for this issue. As promised, the bug fix is also included in there.
Here's the link for easier access: #3404.
I'm not sure if you're the one responsible for reviewing it, but if there is any problem or advice, just let me know.

@ConnorYoh
Copy link
Contributor Author

Thanks @JoseQuintas2003, we will take a look and get back to you, thanks for your hard work. It's greatly appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Front End Issues or pull requests related to front-end development
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants