Skip to content

Allow including templates from source during PR builds #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 3, 2025
Merged

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Feb 27, 2025

  • separate build and deploy as unique jobs (so we can re-run deployment to staging after a stage/prod swap)
  • update action versions
  • align styles with other Steeltoe GH Actions
  • alter the GitHub actions and dockerfile to add support for including templates built from source code rather than nuget.org.

Use the syntax below for specifying what should be checked out:

template_checkout_target=update-for-Steeltoe-v4

Copy link

github-actions bot commented Feb 27, 2025

Preview link: https://netcoretoolservice-pr-11.azurewebsites.net

  • Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
  • The preview link is shareable, but will be deleted when the pull request is merged or closed.

This is an automated message.

@TimHess TimHess marked this pull request as ready for review February 27, 2025 19:43
@TimHess TimHess requested a review from bart-vmware February 27, 2025 20:44
@TimHess TimHess self-assigned this Feb 27, 2025
bart-vmware
bart-vmware previously approved these changes Feb 28, 2025
@bart-vmware bart-vmware self-requested a review February 28, 2025 13:40
@bart-vmware bart-vmware dismissed their stale review February 28, 2025 13:41

Navigating to the preview link does not work.

bart-vmware
bart-vmware previously approved these changes Mar 3, 2025
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked deeply in how this all works, but I trust you figured it out.

@TimHess TimHess merged commit 21cfd96 into main Mar 3, 2025
3 checks passed
@TimHess TimHess deleted the workflows branch March 3, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants