-
Notifications
You must be signed in to change notification settings - Fork 71
feat: Add SkinStyles to StructuredNavigation #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SkinStyles to StructuredNavigation #943
Conversation
Signed-off-by: Pisces <admin@songngu.xyz>
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes introduce a new entry for the "StructuredNavigation" extension in the README.md, detailing its grade, version, and last updated date. Additionally, a stylesheet reference for the extension is added in the skin.json file, along with a new LESS file that defines styles for the Structured Navigation component, enhancing the visual design of the navigation interface. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- README.md (1 hunks)
- skin.json (1 hunks)
- skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less (1 hunks)
Files skipped from review due to trivial changes (2)
- README.md
- skin.json
Additional comments not posted (4)
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less (4)
1-9
: Clear and informative header comments.The header comments effectively communicate the purpose, version, and date of the stylesheet. This is crucial for maintainability and understanding the context of the styles.
12-17
: Well-defined container styles.The use of CSS variables for theming and standard properties for styling the navigation container enhances the visual consistency and maintainability of the styles.
19-30
: Effective use of specificity and clear documentation.The
.mw-structurednav-header
styles are well-defined, and the nested.mw-structurednav-header-title
uses increased specificity to override default styles. The accompanying comment by Samantha Nguyen adds valuable context for future maintainers.
33-43
: Consistent and reusable group styles.The shared border-top style for
.mw-structurednav-group-title
and.mw-structurednav-group-content
enhances consistency, while specific styles for the title element ensure visual distinction and readability.
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
From right to left, for the sake of readability. Signed-off-by: Pisces <vuminhnguyen@songngu.xyz>
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
Per review from @alistar3149
@alistair3149 review ready |
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
skinStyles/extensions/StructuredNavigation/ext.structuredNav.NavigationView.less
Outdated
Show resolved
Hide resolved
Another review-based patch
|
Thanks for the PR and changes! Merging now |
Extension: https://www.mediawiki.org/wiki/Extension:StructuredNavigation
Gerrit (REL1_39): https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/StructuredNavigation/+/refs/heads/REL1_39/
Summary by CodeRabbit
New Features
Enhancements