Skip to content

feat(typography): ✨ improve emphasis styles for East Asian scripts #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2025
Merged

feat(typography): ✨ improve emphasis styles for East Asian scripts #1165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3c0c29
feat(typography): ✨ improve emphasis styles for East Asian scripts
AmeroHan Oct 16, 2025
bc02e53
style(typography): 🎨 use block comment instead of slash comment
AmeroHan Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions resources/skins.citizen.styles/common/typography.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,23 +55,43 @@ figcaption {
}

em {
/**
* Languages that do not use italics for emphasis
*
* References:
* - zh: {@link https://www.w3.org/TR/2025/DNOTE-clreq-20251008/#id84}
* - ja: {@link https://www.w3.org/TR/2020/NOTE-jlreq-20200811/#composition_of_emphasis_dots}
* - mn: {@link https://www.w3.org/TR/2025/DNOTE-mlreq-20250710/#h_emphasis}
* - ko: emphasis not mentioned in klreq, further investigation needed
*
* We assume that `mn` without `-Mong` is written in Cyrillic, namely `mn-Cyrl`
*/
&:lang( zh ),
&:lang( ja ),
&:lang( ko ),
&:lang( mn ),
&:lang( zh ) {
/* CJK languages do not use italics for emphasis */
&:lang( mn-Mong ) {
font-style: normal;
text-emphasis: filled;
}

&:lang( zh ) {
-webkit-text-emphasis: filled dot;
text-emphasis: filled dot;
-webkit-text-emphasis-position: under;
text-emphasis-position: under right;
}

&:lang( ja ),
&:lang( ko ),
&:lang( mn ) {
&:lang( ko ) {
-webkit-text-emphasis: filled;
text-emphasis: filled;
-webkit-text-emphasis-position: over;
text-emphasis-position: over right;
}

&:lang( zh ) & {
text-emphasis-position: under right;
&:lang( mn-Mong ) {
// For vertical text, wavy line should appear on the right side
// but we are unable to implement that
text-decoration: underline wavy;
}
Comment on lines +91 to 95
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Convert remaining slash comment to block comment.

CI previously failed on no-invalid-double-slash-comments; these new // lines will keep tripping stylelint. Switch them to a /* … */ block to satisfy the linter.

-		// For vertical text, wavy line should appear on the right side
-		// but we are unable to implement that
+		/* For vertical text, wavy line should appear on the right side,
+		 * but we are unable to implement that */
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
&:lang( mn-Mong ) {
// For vertical text, wavy line should appear on the right side
// but we are unable to implement that
text-decoration: underline wavy;
}
&:lang( mn-Mong ) {
/* For vertical text, wavy line should appear on the right side,
* but we are unable to implement that */
text-decoration: underline wavy;
}
🤖 Prompt for AI Agents 
In resources/skins.citizen.styles/common/typography.less around lines 91 to 95,
the two single-line `//` comments inside the `&:lang( mn-Mong )` block violate
the `no-invalid-double-slash-comments` linter rule; replace those `//` comments
with a single or two `/* ... */` block comments (e.g., convert each `// ...`
into `/* ... */` or combine into one `/* For vertical text, wavy line should
appear on the right side but we are unable to implement that */`) so the file
uses valid block comments and stylelint stops failing.

}

Expand Down