Skip to content

Conversation

d8ahazard
Copy link

Package was making it very difficult to install other packages that depend on things like numpy, laion-clap, pandas, etc.

Package was making it very difficult to install other packages that depend on things like numpy, laion-clap, pandas, etc.
@zqevans
Copy link
Collaborator

zqevans commented May 14, 2025

Happy to make some changes to the dependencies to speed things up. My Python build knowledge is a bit lacking, what is the point of having the dependencies listed in both setup.py and pyproject.toml?

I see a few imports are being added here (accelerate, numpy, httpcore), what are those for?

Our flex attention code also needs PyTorch 2.5+, so that version should be bumped up.

@d8ahazard
Copy link
Author

Happy to make some changes to the dependencies to speed things up. My Python build knowledge is a bit lacking, what is the point of having the dependencies listed in both setup.py and pyproject.toml?

I see a few imports are being added here (accelerate, numpy, httpcore), what are those for?

Our flex attention code also needs PyTorch 2.5+, so that version should be bumped up.

I'd be lying if I said there was a strict reason to have the deps specifically spelled out in both files. I'm not an expert on pyproject.toml files or the newer build system, so there may be a more elegant or preferred way to do this. I just added the new file and updated both with the same dependencies so of any existing ci/cd pipelines were using setup.py, it wouldn't break anything.

The extra imports were unintentional - I have a utility set up where I'm dealing with multiple repos like this where I was getting import issues (numpy...lol...I hate numpy), and one of my early scripts got a bit too excited and inserted the same deps in all the projects setup files. Everything builds fine, but yeah, totally unneeded.

I've removed these, and bumped the torch version as requested.

@zqevans
Copy link
Collaborator

zqevans commented May 17, 2025

needing to maintain identical dependencies in two different files sounds like a bug waiting to happen. I'd rather keep pyptoject.toml minimal as it was, I believe it's only in there so I can run the build command to make the pypi package.

d8ahazard and others added 2 commits May 22, 2025 09:49
Co-authored-by: Thomas Schaller <me@torkleyy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants