Remove accidentally committed secrets #19
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jwbram <jwbram@gmail.com>
- Fixed minion damage input to start at 1 instead of 0 - Implemented consistent '+X additional minion(s)' format - Added font-variant-numeric: tabular-nums to prevent number width shifts - Eliminated layout shifts between different damage amounts - Simplified text to use 'minion(s)' to avoid pluralization shifts - Improved UX with stable, predictable damage feedback
- Restored deploy.yml workflow from .disabled state - Auto-deploy will now trigger on every push to main branch - Uses peaceiris/actions-gh-pages@v3 for reliable deployment - Builds project and deploys dist/ folder to GitHub Pages
- Using peaceiris/actions-gh-pages@v3 as intended - Need to configure GitHub Pages source to GitHub Actions
- Switched to actions/configure-pages and actions/deploy-pages - Uses proper permissions and environment setup - Modern approach that works directly with GitHub Pages - No need for gh-pages branch or external tokens
- Uses the same deployment method that works manually - Runs npm run deploy automatically on every push to main - Should work since manual deployment works perfectly
- Merged remote workflow changes with local deploy.yml updates - GitHub Actions now configured for automatic deployment - Uses npm run deploy method that works reliably
- Removed GitHub Actions workflow files (deploy.yml, static.yml) - Manual deployment is working perfectly - Updated TODO.md to reflect cleanup - No need for paid GitHub Actions when manual works great
- Remove horizontal rules between count/env/adv sections - Add top padding to section headers for better spacing - Fix section title alignment to be left-aligned - Revert browser table changes that caused column visibility issues - Update TODO.md with completed tasks
- Fixed horizontal overflow on narrow desktop widths - Made columns content-sized instead of header-sized - Replaced 'Special (see Relative Strength)' with tilde symbol (~) - Made add button fill entire cell with no padding (35x35px) - Replaced column headers with symbols (# for tier, ⚔ for difficulty) - Made mobile browser table match desktop exactly - Unified row height (35px) and padding (0.25rem) across all rules - Fixed conflicting CSS rules that were causing desktop/mobile differences
- Implemented multi-level sorting with persistent state per browser type - Added sticky header with dark background and consistent borders - Centered Type column and updated width to fit 'Exploration' - Fixed Name column header/content padding alignment - Removed redundant category filter (separate browsers handle this) - Used proper Lucide icons (Star for tier, Skull for difficulty) - Fixed filter dropdown positioning - Improved table column sizing and overflow handling - Zero jitter when switching between adversary/environment browsers - Better visual hierarchy with darker header and consistent styling
- Implement collapsible sections (countdowns, environments, adversaries) with localStorage persistence - Add mobile drawer for browser/creator with smooth transitions and swipe gestures - Position mobile drawer below fear header (no dimming) for better UX - Fix section visibility persistence across mobile/desktop transitions - Reuse existing drawer patterns for consistent behavior - Add touch handling for swipe-to-dismiss on mobile drawers - Auto-expand sections when items are added from browser - Reserve space for expand/collapse icons to prevent layout shifts - Fix HP display in browser cards (show 0 HP = healthy, not max HP) - Improve mobile scrolling behavior in drawer content
Mobile Drawer & Touch Interactions: - Fixed pull-to-refresh prevention while preserving scrolling functionality - Enhanced mobile drawer touch handling for browser and expanded card drawers - Browser drawer: pull-to-close works anywhere on card, only on scrollable table when at top - Expanded card drawer: fixed scrolling for long adversary cards on mobile Safari - Prevented unwanted scroll when pushing back up after partial swipe-to-close gesture - Improved CSS touch-action and overscroll-behavior for better mobile compatibility Number Input Improvements: - Added inputMode='numeric' to all number input fields for mobile number pad - Added enterKeyHint='done' to show 'Done' button instead of 'Return' on number pads - Applied to damage inputs, HP/stress fields, countdown values, and creator forms UI Layout & Styling: - Fixed excessive left padding on section headers (reduced from 1rem to 0.25rem) - Added zoom prevention to fear bar and bottom toolbar with touch-action: manipulation - Enhanced mobile Safari compatibility with -webkit-overflow-scrolling: touch - Improved drawer body scrolling with proper touch-action: manipulation App Layout & Viewport: - Restructured main app layout using flexbox for proper bottom toolbar positioning - Fixed iOS Safari viewport issues with 100dvh and safe area insets - Prevented app-level scrolling when drawers are open - Fixed bottom toolbar positioning and jitter issues on window resize Touch Event Handling: - Enhanced swipe-to-dismiss with smooth closing animations - Added click-to-close functionality on drawer headers - Improved touch gesture detection and handling across all drawer types - Fixed pull-to-refresh conflicts while maintaining scroll functionality Files modified: App.css, App.jsx, Cards.jsx, Creator.jsx, InlineCountdownCreator.jsx, AdversaryCreatorMockup.jsx, List.jsx, index.css (392 additions, 68 deletions)
- Fixed pull-to-refresh still happening below drawer handle by making CSS more aggressive - Set drawer-body touch-action to 'none' to prevent all touch gestures - Added specific touch-action: pan-y only for scrollable areas (browser table, expanded content) - Fixed errant scroll up when releasing partial swipe-to-close gesture - Always prevent default and stop propagation in handleTouchEnd - Clear touch state after snap-back to prevent unwanted scroll behavior - Enhanced touch state management to prevent scroll conflicts This should eliminate both pull-to-refresh and unwanted scroll behaviors.
- Added automatic version numbering using git commit hash - Version displays in top-right corner with semi-transparent background - Updates automatically with each deployment - Responsive design for mobile and desktop - Non-interactive overlay that doesn't interfere with UI - Uses monospace font for clear readability - Includes backdrop blur and subtle border for visibility Files added: - src/components/Version.jsx - Version display component - config/vite.config.js - Updated to inject git commit hash - src/App.jsx - Added Version component to main app - src/index.css - Added version display styles This allows easy verification when GitHub Pages has updated.
- Replaced conflicting CSS touch-action rules with JavaScript-controlled touch events - Set all drawer elements to touch-action: auto to let JavaScript handle events - Implemented intelligent touch event handling: * Only prevents default for actual swipe-to-dismiss gestures * Allows normal scrolling when not handling swipe gestures * Prevents pull-to-refresh only when needed * Clears touch state properly to prevent unwanted scroll behavior Touch handling logic: - handleTouchStart: Only prevents default for swipe-to-dismiss gestures - handleTouchMove: Only prevents default for downward swipes > 0px - handleTouchEnd: Only prevents default for significant swipes > 30px - Proper touch state clearing prevents errant scroll after snap-back This should finally resolve the back-and-forth between broken scrolling and broken pull-to-refresh prevention by giving precise control over when touch events are intercepted vs allowed to pass through for normal scrolling.
EXPANDED CARD DRAWER (List.jsx) - Scroll-First Strategy: - Only handles swipe-to-dismiss on header touches - All content touches allow normal scrolling (no preventDefault) - CSS: touch-action: pan-y for scrolling, JavaScript handles swipe-to-dismiss - Prioritizes scrolling for long adversary/environment content BROWSER/CREATOR DRAWER (App.jsx) - Table-Aware Strategy: - Intelligently handles table scrolling vs swipe-to-dismiss - Table touches: allow scrolling when scrolled down, swipe-to-dismiss when at top - Non-table touches: always handle swipe-to-dismiss - CSS: touch-action: pan-y for table scrolling, JavaScript handles swipe-to-dismiss Key Differences: - Expanded cards: Header-only swipe-to-dismiss, content always scrolls - Browser drawer: Context-aware (table scroll position determines behavior) - Both prevent pull-to-refresh via overscroll-behavior: none - Both use touch-action: pan-y to allow scrolling while JavaScript handles gestures This separation should end the back-and-forth by giving each drawer type the appropriate touch handling strategy for its specific use case.
- Expanded card drawer now handles swipe-to-dismiss from both header AND scrollable content when at top - Added check for drawerBody.scrollTop <= 10 to detect when content is scrolled to top - Behavior: Header always swipe-to-dismiss, content swipe-to-dismiss when at top, content scroll when scrolled down - This matches the browser drawer behavior for consistency Touch handling logic: - isHeaderTouch: Always handle swipe-to-dismiss - isContentAtTop: Handle swipe-to-dismiss when content is at top - Content scrolled down: Allow normal scrolling (no preventDefault) Now both drawer types have consistent swipe-to-dismiss behavior: - Browser drawer: Table swipe-to-dismiss when table at top - Expanded card drawer: Content swipe-to-dismiss when content at top
- Added handle touch handling to prevent pull-to-refresh - Added CSS rules for browser wrapper/top-row/filters to prevent pull-to-refresh - Browser drawer now prevents pull-to-refresh in all areas except scrollable table
- Always prevent pull-to-refresh everywhere in browser drawer - Handle table scrolling via CSS touch-action: pan-y - Simplified JavaScript to always preventDefault and handle swipe-to-dismiss
- Persist selected filters per type (adv/env) in localStorage - Reconcile saved filters with available data on type switch to avoid blanks - Fix crash from effect using uninitialized variables - Keep dropdown open when selecting; close only on click-away - Position dropdowns under header cell; clamp to viewport - Size dropdowns to content with max-width, prevent overflow - Redesign dropdown options with checkboxes; remove purple flood and headers - Lighter separators, improved hover; tooltips show selection count - Minor CSS tweaks and cleanup
- Add filter active indicators with purple icon and centered dot badge - Tighten browser header layout: compact search/create row, remove gap above table - Fix mobile/desktop transitions to prefer drawers over panel switching - Apply duplicate handling to environments (same as adversaries with numbering) - Remove drawer body padding, add handle margin for better touch targets
…ne; wire into App and GameBoard - Rename Creator countdown field to countdownType, map to type on save - Add utils/countdownEngine for triggers and advancement calculations - Replace duplicated logic in App.jsx and GameBoard.jsx with engine calls
… JSON; vendor chunking; accessibility + icon updates; CSS tokens - Add hooks/useSwipeDrawer and wire into App/List - Lazy-load Browser/Creator via React.lazy + Suspense - Dynamic import data JSON in Browser - Vite manualChunks for dndkit/fa/lucide - Replace emoji edit icon with Pencil; add ARIA labels - Add common CSS tokens (primary/success/gold)
- Exit clear mode when switching from clear to help button - Exit clear mode when closing floating menu - Exit clear mode when clicking outside floating menu - Ensure clear mode is properly reset in all navigation scenarios - Increment version to 0.2.31
…ct cards - Set fixed minimum width (200px) for right side container - Add justifyContent: 'flex-end' to align content to right edge - Prevents variable spacing caused by different type text lengths and HP/stress pip counts - Ensures consistent spacing between difficulty badge and card edge - Increment version to 0.2.32
- Change clear button logic to exit clear mode when already in clear mode - Previously only toggled flyout, now properly exits clear mode and closes flyout - Ensures clear button acts as a proper toggle for clear mode - Increment version to 0.2.33
- Add fixed width (40px) to type badge spans - Add display: 'block' to ensure consistent layout - Prevents variable spacing caused by different type text lengths (Minion vs Elite vs Boss) - Ensures consistent spacing between difficulty badge and card edge - Applied to all type badge instances for consistency - Increment version to 0.2.34
- Increase width from 40px to 50px to accommodate 'Standard' (8 characters) - Add paddingLeft: 0 to remove any left padding - Ensures all type texts fit properly: Standard, Bruiser, Minion, Social, Solo, Skulk - Prevents text from being pushed to the side - Maintains consistent spacing for all adversary types - Increment version to 0.2.35
- Reduce gap from 0.5rem to 0.25rem in right side container - Creates tighter, more efficient layout in compact cards - Reduces unnecessary white space between pip groups and badge groups - Maintains visual hierarchy while improving space utilization - Increment version to 0.2.36
- Expand difficulty badge tap area to include entire type/difficulty section - Add generous padding (0.5rem) and hover effects to difficulty container - Expand HP/stress pip tap areas with increased padding (0.5rem vertical, 0.25rem horizontal) - Increase browser add button size from 24px to 32px for better tap target - Increase add button font size from 14px to 16px for better visibility - Update browser column width to accommodate larger add button - All tap targets now more generous and easier to hit on mobile - Increment version to 0.2.37
- Fix type/badge visual area being too big by using negative margin - Keep generous tappable area but make visual area normal size - Fix gap between HP and stress pips that was opening expanded card - Add padding to HP/stress container with negative margin to cover gap - Now tapping between HP and stress pips interacts with pips instead of opening card - Maintains generous tap targets while keeping visual design clean - Increment version to 0.2.38
- Create new SortButton component with ArrowUpDown icon - Implement sort logic: type first, then name (including duplicate numbers) - Add SortButton to floating menu between Help and Clear buttons - Add sortAdversaries function to Layout.jsx using updateAdversary - SortButton has generous tap target (48px) and visual feedback - Disabled state when no adversaries to sort - Maintains consistent styling with other floating menu items - Increment version to 0.2.39
- Increase right padding from 0.25rem to 0.5rem for HP and stress pip containers - Maintains left padding at 0.25rem to avoid interfering with layout - Provides more generous tap target on the right side of pips - Makes it easier to tap HP and stress pips, especially on mobile - Increment version to 0.2.40
Co-authored-by: jwbram <jwbram@gmail.com>
- Fix HP and stress pip alignment with symmetrical padding - Implement proper adversary sorting with reorderAdversaries function - Add type priority sorting: Leader, Bruiser, Horde, Ranged, Standard, Other, Minions - Convert floating menu from vertical to radial layout - Menu items now spread in a 90-degree arc around the main button - Improved visual appeal and modern UX - Increment version to 0.2.41
- Remove conditional top bar rendering (was desktop-only) - Move fear bar to always be in the bottom bar for all screen sizes - Update CSS height calculations to only subtract bottom bar (60px) - Simplify layout by removing top bar complexity - Consistent fear bar placement across all devices - Increment version to 0.2.42
- Remove top bar entirely, fear bar now always in bottom bar - Update CSS height calculations to only subtract bottom bar (60px) - Add custom scrollbar styling for cleaner appearance: - Webkit browsers: thin gray scrollbars with transparent track - Firefox: thin scrollbars with gray thumb and transparent track - Optional invisible-scrollbar class for completely hidden scrollbars - Improves visual consistency across all browsers - Increment version to 0.2.43
- Change radial menu to radiate up and left (90° to 180°) instead of up only - Reduce radius from 80px to 60px to prevent spilling out of window - Menu items now spread in a more contained arc toward the top-left - Better positioning for right-side floating menu button - Increment version to 0.2.44
- Fix trigonometry calculations: use cos for x, sin for y - Adjust angle range to 120° to 180° for proper up-left arc - Menu items now correctly radiate up and left from main button - Proper coordinate system alignment with CSS positioning - Increment version to 0.2.45
- Correct angle range from 90° (straight up) to 180° (straight left) - This creates the proper up-and-left arc as requested - Menu items now spread correctly from up to left - Increment version to 0.2.46
- Change radiation arc to 180° to 270° (left to down direction) - Reduce HP/stress pip padding from 0.5rem to 0.25rem to make compact cards shorter - Simplify sort adversaries function to properly reorder by type priority - Sort button now works as single tap with Leader->Bruiser->Horde->Ranged->Standard->Other->Minions - Increment version to 0.2.47
- Increase radius from 60px to 70px for better button spacing - Fix container positioning to properly center radial items on main button - Remove gap from container and set fixed width/height to match button size - Radial items container now positioned absolutely at top-left of main button - Better visual alignment and less cramped appearance - Increment version to 0.2.48
- Add paddingTop: 0 and paddingBottom: 0 to compact card styling - Let pip padding handle the vertical spacing instead of card padding - Makes compact cards more compact and tighter - Pip padding already provides adequate tap targets - Increment version to 0.2.49
Co-authored-by: jwbram <jwbram@gmail.com>
- Move delete/clear button to position 0 (first in radial arc) - Move help button to position 2 (last in radial arc) - Sort button remains in middle position - New order: Clear -> Sort -> Help (left to down arc) - Increment version to 0.2.50
- Add bulkReorderAdversaries function to GameCard actions - Export and integrate bulkReorderAdversaries in state management - Simplify sortAdversaries to use bulk reorder instead of complex index manipulation - Sort button now works properly with single tap - Sorts by type priority: Leader -> Bruiser -> Horde -> Ranged -> Standard -> Other -> Minions - Then alphabetically by name (including duplicate numbers) - Increment version to 0.2.51
- Solo moved above Leader (priority 1) - Leader now priority 2 - Skulk added before Ranged (priority 5) - Support added after Ranged (priority 7) - Social added after Minion (priority 11) - Complete type priority order: 1. Solo 2. Leader 3. Bruiser 4. Horde 5. Skulk 6. Ranged 7. Support 8. Standard 9. Other 10. Minion 11. Social - Updated default priority fallback to 9 (Other) - Increment version to 0.2.52
- Removed 'Other' type from sort priority list - Updated priority numbers: Minion now 9, Social now 10 - Changed default fallback from 9 to 999 for unknown types - Cleaner type system with only actual adversary types - Final sort order: Solo -> Leader -> Bruiser -> Horde -> Skulk -> Ranged -> Support -> Standard -> Minion -> Social - Increment version to 0.2.53
- New sort order: Solo -> Bruiser -> Leader -> Horde -> Standard -> Ranged -> Skulk -> Support -> Minion -> Social - Key changes: - Bruiser moved up to position 2 (was 3) - Leader moved down to position 3 (was 2) - Standard moved up to position 5 (was 8) - Ranged moved down to position 6 (was 5) - Skulk moved down to position 7 (was 5) - Support moved down to position 8 (was 7) - Increment version to 0.2.54
- Remove transition from HP and stress pip containers - Change transition from 'all 0.2s ease' to 'none' - Prevents visual flashing/flickering when interacting with pips - More stable and responsive pip interaction - Increment version to 0.2.55
- Remove transition from adversaryStress pipStyle in Pips.jsx - Remove transition from adversaryHP pipStyle for consistency - Change transition from 'color 0.3s ease' to 'none' - This fixes the remaining flashing issue with stress pips - Both HP and stress pips now have no transitions for stable interaction - Increment version to 0.2.56
Co-authored-by: jwbram <jwbram@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains changes generated by Cursor background composer.