Allow multiple dialogs by using the default dialog mechanism in trix #1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I believe the original |
|
It was indeed! It just doesn't fit this purpose, and Trix has its own dialog management, so why tinker :) |
Bramjetten
reviewed
Oct 15, 2025
spina.gemspec
Outdated
| gem.add_dependency "jsonapi-serializer" | ||
| gem.add_dependency "browser" | ||
| gem.add_dependency "tailwindcss-ruby" | ||
| gem.add_dependency "tailwindcss-ruby", '< 4.0' |
There was a problem hiding this comment.
This makes sense, but it does break projects using Tailwind v4. I should probably upgrade Spina to use Tailwind v4 as well.
There was a problem hiding this comment.
It doesn't CI properly unless that's added in at the moment. It does break, and I don't like it being there.
There was a problem hiding this comment.
I think the right solution here is to remove this actually, and to upgrade TW in a separate PR, then rebase this and confirm all works and merge.
simmerz
force-pushed
the
multiple_trix_dialogs
branch
from
95a4b9f to
98521be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight design change in the link modal to stop it overlapping other editors.
Primary focus of this PR is to allow multiple buttons to have dialogs by reverting back to the native mechanism in trix.
I've had to add a comment with some tw classes, to force the tailwind builder to see them. Happy to remove, but didn't know a better way to handle that whilst still on older versions of tailwind-ruby/rails and not using the new engine features in importmaps.