This repository was archived by the owner on May 14, 2020. It is now read-only.
Fix XSS requesting 'capture' action #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's nasty. Thanks for the PR. You created it to fix 3.0. I fear this might be forgotten for 3.1. Can't we push to 3.1 and then backport? Are we creating an issue for ModSec too? |
|
I can make another request for 3.1. I'm also going to open a modsec issue right... meow! |
|
Yes, please also do a PR to 3.1. Merging this now. |
emphazer
added a commit
to emphazer/owasp-modsecurity-crs
that referenced
this pull request
Jul 4, 2017
according to PR SpiderLabs#828 before we forget it ;-)
|
Proposed fix here: owasp-modsecurity/ModSecurity#1488 |
|
Thank you @victorhora. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Capture action isn't supported by @ detectxss but is supported by @ detectsqli. This is pretty awful in general and should probably be fixed. In any event the current capture was actually not setting TX.0 and therefore getting it from the previous rule that set it.
Thanks to @fschwindt for pointing this out.