Skip to content

Add some nominal types for representing algebra elements #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mcy
Copy link
Contributor

@mcy mcy commented Oct 24, 2021

This is a WIP, since I expect it to tear up a lot of function signatures in algebra, sseq, and ext. I'm pushing it now to get feedback on the design.

@mcy
Copy link
Contributor Author

mcy commented Oct 24, 2021

@dalcde Feedback appreciated

@dalcde
Copy link
Contributor

dalcde commented Oct 24, 2021 via email

@mcy
Copy link
Contributor Author

mcy commented Nov 4, 2021

Just an update; I've been super hosed the last weeks and have been punting on this since I haven't been approaching this a great way. I think I'll take a look at redoing this by adding a separate, parallel product trait function that uses the new element types (and is just a thin wrapper) and gradually switch everything over to using those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants