-
Notifications
You must be signed in to change notification settings - Fork 12
Introduce finer save structure #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: save3.0
Are you sure you want to change the base?
Conversation
@hoodmane Any thoughts on this? This is getting relevant again as we're prepping for more computations soon. I was thinking, since this isn't backwards-compatible with the current save format anyway (although fairly close), that this would also be a good time to rename the files themselves. For many purposes, it's more convenient to have |
Sorry for the super long delay in review. I'll try to take a look soon, but if you need it feel free to merge. It would be nice if we could get someone else to contribute/review changes. But it's hard. |
Maybe |
No worries! If it had been urgent I would have pinged you earlier but I get that other things get in the way sometimes.
Agreed. It seems like the intersection of people who are proficient in both Rust and computational homotopy theory isn't very big, or maybe they prefer spending their time on their own projects.
Yeah but I'm really uneasy about special characters like that in filenames. Also, I tried putting the kind first but it breaks one of the tests in a nontrivial way because it makes the filename harder to parse. If we look at segments delimited by '_', then the stem is either the second or third segment, because kinds sometimes have underscores in their name. It's also either the second to last or third to last, because sometimes we have an extra |
This should solve #123