-
Notifications
You must be signed in to change notification settings - Fork 2
BHCS317-Update-Permissions-Article #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHCS317-Update-Permissions-Article #15
Conversation
WalkthroughDocumentation was updated to unify and generalize the "SharpHound Data Collection and Permissions" content, making it applicable to both BloodHound Enterprise and Community Edition. Multiple internal and navigation links were updated to reference the new, centralized permissions page location. Related cards and references specific to the Enterprise collection were removed or modified for consistency. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/collect-data/permissions.mdx (1)
12-12
: Suggest adding comma after introductory phrase
Consider writing “In BloodHound Enterprise, you can start scans…” for clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (12)
docs/collect-data/enterprise-collection/ad-hoc-collection.mdx
(1 hunks)docs/collect-data/enterprise-collection/collection-schedule.mdx
(1 hunks)docs/collect-data/enterprise-collection/on-demand-scan.mdx
(1 hunks)docs/collect-data/enterprise-collection/overview.mdx
(0 hunks)docs/collect-data/overview.mdx
(0 hunks)docs/collect-data/permissions.mdx
(2 hunks)docs/docs.json
(1 hunks)docs/get-started/security-boundaries/enterprise-security-overview.mdx
(1 hunks)docs/install-data-collector/install-sharphound/system-requirements.mdx
(2 hunks)docs/install-data-collector/install-sharphound/tenant-configuration.mdx
(1 hunks)docs/install-data-collector/install-sharphound/troubleshooting.mdx
(1 hunks)docs/integrations/integrations/overview.mdx
(1 hunks)
💤 Files with no reviewable changes (2)
- docs/collect-data/enterprise-collection/overview.mdx
- docs/collect-data/overview.mdx
🧰 Additional context used
🪛 LanguageTool
docs/collect-data/permissions.mdx
[uncategorized] ~12-~12: Possible missing comma found.
Context: ...rprise Engineering team. In BloodHound Enterprise you can start scans for different data ...
(AI_HYDRA_LEO_MISSING_COMMA)
🔇 Additional comments (15)
docs/integrations/integrations/overview.mdx (1)
30-30
: ServiceHound entry looks good.The new community integration follows the existing formatting and link pattern.
docs/collect-data/permissions.mdx (4)
2-5
: Frontmatter updated correctly
The title, sidebarTitle, mode, and description have been adjusted to reflect the unified page.
8-8
: Pill image reflects both editions
The updated image tag and alt text correctly indicate applicability to Enterprise and Community.
17-25
: AD data list links updated
All bullets now point to the unified/collect-data/permissions
anchors and formatting is consistent.
104-104
: Clarification note addition
The new callout about DC Registry and CA Registry enhances discoverability without altering technical accuracy.docs/get-started/security-boundaries/enterprise-security-overview.mdx (1)
187-187
: Updated SharpHound link
The Data Collection Overview now accurately directs users to the unified permissions page.docs/install-data-collector/install-sharphound/troubleshooting.mdx (2)
5-5
: Pill image updated correctly
The pill tag now covers both Enterprise and CE, matching the unified scope.
7-7
: Troubleshooting link updated
The hyperlink correctly points to/collect-data/permissions
with appropriate link text.docs/install-data-collector/install-sharphound/tenant-configuration.mdx (1)
49-49
: Data link updated in table
The “Data (Required)” row now references the unified permissions page as intended.docs/collect-data/enterprise-collection/collection-schedule.mdx (1)
39-39
: Update link to generic permissions page
The link now correctly points to the unified/collect-data/permissions
page after moving it out of the Enterprise directory.docs/docs.json (1)
84-84
: Add generic permissions page to navigation
Including"collect-data/permissions"
at the top level under the Collect Data group ensures unified access to the permissions documentation. Double-check that there are no lingering references to the old Enterprise-specific path.docs/collect-data/enterprise-collection/ad-hoc-collection.mdx (1)
37-37
: Update link to generic permissions documentation
The reference has been updated to point at/collect-data/permissions
, reflecting the moved and renamed page.docs/install-data-collector/install-sharphound/system-requirements.mdx (3)
49-49
: Update DC Registry link anchor to new permissions page
The anchor now points to/collect-data/permissions#01HR6PT0BG44W65EJJ0WE4H63V
. Please verify that this ID matches the target heading inpermissions.mdx
.
61-61
: Update DC Registry collection permissions link
Link correctly updated to/collect-data/permissions
. Ensure the target page covers DC Registry requirements.
65-65
: Update general permissions reference
The final reference now points to/collect-data/permissions
. Confirm that this page contains the complete, consolidated requirement information.
Closes BHCS317
https://specterops.atlassian.net/issues/BHCS-317
Updated SharpHound permissions page with generic language, updated pill images.
Moved page up one level, updated menu and all references.
Summary by CodeRabbit