-
Notifications
You must be signed in to change notification settings - Fork 2
BHCS-488-added-reference-servicehound #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHCS-488-added-reference-servicehound #14
Conversation
WalkthroughA new community integration called "ServiceHound" has been added to the documentation's list of community-developed integrations, including a link to its GitHub repository. Multiple documentation pages had their SharpHound data collection and permissions links updated from an enterprise-specific path to a unified, general path. The "SharpHound Enterprise Data Collection and Permissions" card was removed from overview pages, and the permissions document was generalized to cover both Enterprise and Community editions. Navigation structure was adjusted accordingly. No functional or code changes were made. Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/integrations/integrations/overview.mdx (1)
30-30
: Remove trailing whitespace from the new list itemThere's an extra space after
@Eli4m
on line 30; trimming it will keep the formatting consistent with the other entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
* BHCS-317-update-initial-language * BHCS-317-updated-menu-and-all-references * BHCS-317-updated-for-rabbit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/collect-data/permissions.mdx (2)
10-12
: Fix double space and improve sentence flow.
There’s a double space and a choppy transition between sentences. Consider merging them for clarity.Proposed diff:
- SharpHound data collection utilizes the open-source [SharpHound Common](https://github.com/BloodHoundAD/SharpHoundCommon) library, maintained by the BloodHound Enterprise Engineering team. In BloodHound Enterprise you can start scans… + SharpHound data collection utilizes the open-source [SharpHound Common](https://github.com/BloodHoundAD/SharpHoundCommon) library, maintained by the BloodHound Enterprise Engineering team, and in BloodHound Enterprise you can start scans…
17-25
: Avoid duplicating registry items.
You list DC Registry and CA Registry both in the primary data types list and again at line 104. Consider removing one occurrence to prevent confusion.Example: Drop them from the top-level list (lines 24–25) since they’re detailed later, or vice versa.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
docs/collect-data/enterprise-collection/ad-hoc-collection.mdx
(1 hunks)docs/collect-data/enterprise-collection/collection-schedule.mdx
(1 hunks)docs/collect-data/enterprise-collection/on-demand-scan.mdx
(1 hunks)docs/collect-data/enterprise-collection/overview.mdx
(0 hunks)docs/collect-data/overview.mdx
(0 hunks)docs/collect-data/permissions.mdx
(2 hunks)docs/docs.json
(1 hunks)docs/get-started/security-boundaries/enterprise-security-overview.mdx
(1 hunks)docs/install-data-collector/install-sharphound/system-requirements.mdx
(2 hunks)docs/install-data-collector/install-sharphound/tenant-configuration.mdx
(1 hunks)docs/install-data-collector/install-sharphound/troubleshooting.mdx
(1 hunks)
💤 Files with no reviewable changes (2)
- docs/collect-data/overview.mdx
- docs/collect-data/enterprise-collection/overview.mdx
✅ Files skipped from review due to trivial changes (8)
- docs/collect-data/enterprise-collection/on-demand-scan.mdx
- docs/get-started/security-boundaries/enterprise-security-overview.mdx
- docs/install-data-collector/install-sharphound/troubleshooting.mdx
- docs/install-data-collector/install-sharphound/tenant-configuration.mdx
- docs/collect-data/enterprise-collection/collection-schedule.mdx
- docs/install-data-collector/install-sharphound/system-requirements.mdx
- docs/collect-data/enterprise-collection/ad-hoc-collection.mdx
- docs/docs.json
🧰 Additional context used
🪛 LanguageTool
docs/collect-data/permissions.mdx
[uncategorized] ~12-~12: Possible missing comma found.
Context: ...rprise Engineering team. In BloodHound Enterprise you can start scans for different data ...
(AI_HYDRA_LEO_MISSING_COMMA)
🔇 Additional comments (4)
docs/collect-data/permissions.mdx (4)
2-5
: Frontmatter update looks good.
The title, sidebarTitle, mode, and description have been correctly generalized to apply to both editions without any missing or inconsistent metadata.
8-8
: Pill tag inclusion is appropriate.
The new badge clearly indicates applicability to both Enterprise and Community editions. Alt text is descriptive and thenoZoom
attribute is valid.
12-14
: Enterprise vs. Community scan instructions are clear.
The split between Enterprise (schedule/on-demand) and Community (direct executable) is correctly presented with valid links.
30-32
: AD Structure Data description is accurate.
The overview and “This information includes:” heading correctly summarize the section’s contents.
Closes BHCS488
https://specterops.atlassian.net/browse/BHCS-488
Add reference link to Eli4m ServiceHound
Summary by CodeRabbit