-
Notifications
You must be signed in to change notification settings - Fork 2
fix: BED-5766 Fix Accept-Eula endpoint verb #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe API documentation for the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/reference/eula/accept-eula.mdx (1)
2-2
: Use uppercase HTTP method for consistencyMost OpenAPI frontmatter entries in this repo use uppercase HTTP verbs. Consider updating to:
- openapi: put /api/v2/accept-eula + openapi: PUT /api/v2/accept-eula
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/reference/eula/accept-eula.mdx
(1 hunks)
🔇 Additional comments (1)
docs/reference/eula/accept-eula.mdx (1)
2-2
: HTTP verb updated correctlyChanging the Accept-EULA endpoint from
GET
toPUT
aligns with the intended update operation and resolves BED-5766.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fixes the HTTP verb for the Accept-Eula endpoint
Resolves: BED-5766
Summary by CodeRabbit
/api/v2/accept-eula
endpoint now uses thePUT
HTTP method instead ofGET
.