4603 BHL url to CitationDocumentation #4605
Open
+137
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality to add (please correct/amend/etc.)
@mjy has a much fuller/clearer picture of the goals here, these are my scattered rememberings of what we discussed.
BHL reference should be more than just a url, it should include page mapping (from BHL page numbers to article page numbers) and perhaps ocr mapping as well
Relation to #4603: as discussed there, likely we'll want to create a 'virtual document' to represent the BHL document, and a (new) CitationDocumentation object to associate the (TN, TN source, BHL copy of TN source) data, which is where the page mapping etc data will live.