Return error to user on CollectingEvent#clone when increment_id fails #4601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to 500. The error is that when the identifier has no numeric part, like 'asdf' say, then the increment returns the boolean `false` as the value of the Identifier#identifier, which causes an exception, which gets caught in the clone transaction, which then returns `nil` (*not* `a`). Exception report: ``` A NoMethodError occurred in collecting_events#clone: undefined method 'persisted?' for nil app/controllers/collecting_events_controller.rb:61:in 'block in CollectingEventsController#clone' ------------------------------- Github link: ------------------------------- https://github.com/SpeciesFileGroup/taxonworks/blob/2605ba088/app/controllers/collecting_events_controller.rb#L61 ------------------------------- Request: ------------------------------- * URL : https://sandwich.taxonworks.org/collecting_events/1252283/clone * HTTP Method: POST * IP address : 147.219.179.95 * Parameters : {"annotations" => true, "incremented_identifier_id" => 6298365, "controller" => "collecting_events", "action" => "clone", "id" => "1252283", "collecting_event" => {}} ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to 500. The error is that when the identifier has no numeric part, like 'asdf' say, then the increment returns the boolean
falseas the value of the Identifier#identifier, which causes an exception, which gets caught in the clone transaction, which then returnsnil(nota).Exception report: