Drop support for versions below Ruby 3.2 and Rails 7.1 #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorcery only supports the currently officially supported versions of Ruby and Rails. Also remove conditionals for Rails versions older than 7.0, and mongoid versions older than 4.0 Mongoid 3.x is no longer relevant since its latest release (v3.1.7) depends on `activemodel ~> 3.2`, which is incompatible with current versions of Sorcery. See: https://github.com/mongodb/mongoid/blob/v3.1.7/mongoid.gemspec#L22
|
I tried to add @Beartech as a reviewer, but I couldn't. 
|
|
@willnet oh, can you remove the testing matrix from the readme? No longer needed as we removed the exclusions. |
|
@joshbuker Thank you for the feedback. I'll create a follow-up PR later. |
willnet
added a commit
to willnet/sorcery
that referenced
this pull request
Jun 23, 2025
followup Sorcery#383 Remove the matrix as it is no longer needed. We could mention support for Ruby 3.2+ and Rails 7.1+ in the README, but for now, I just removed the matrix.
willnet
added a commit
to willnet/sorcery
that referenced
this pull request
Jun 23, 2025
followup Sorcery#383 Remove the matrix as it is no longer needed. We could mention support for Ruby 3.2+ and Rails 7.1+ in the README, but for now, I just removed the matrix.
joshbuker
pushed a commit
that referenced
this pull request
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorcery only supports the currently officially supported versions of Ruby and Rails.
Also remove conditionals for Rails versions older than 7.0, and mongoid versions older than 4.0
Mongoid 3.x is no longer relevant since its latest release (v3.1.7) depends on
activemodel ~> 3.2, which is incompatible with current versions of Sorcery. See: https://github.com/mongodb/mongoid/blob/v3.1.7/mongoid.gemspec#L22