Skip to content

Remove unused SimpleCov #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Remove unused SimpleCov #374

merged 2 commits into from
Jul 3, 2024

Conversation

willnet
Copy link
Member

@willnet willnet commented Jul 3, 2024

I couldn’t find any code using SimpleCov, other than the commented-out sections removed in this commit, so it seems SimpleCov is not currently in use.

I couldn’t find any code using SimpleCov, other than the commented-out sections removed in this commit, so it seems SimpleCov is not currently in use
@willnet willnet changed the title Removed unused SimpleCov Remove unused SimpleCov Jul 3, 2024
@willnet willnet requested a review from joshbuker July 3, 2024 10:33
Copy link
Member

@joshbuker joshbuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be properly utilized in v1, but for now no reason to keep it if it's fully disabled. I think v0 also doesn't have RuboCop enabled either iirc.

@joshbuker joshbuker merged commit d8ce48a into master Jul 3, 2024
20 checks passed
@joshbuker joshbuker deleted the remove-no-loger-used-simplecov branch July 3, 2024 16:12
@willnet
Copy link
Member Author

willnet commented Jul 4, 2024

@joshbuker Thank you for merging. In my opinion, since no one has enough time to complete v1 at the moment, it would be better to gradually improve v0. Therefore, if you think it would be good to have test coverage or RuboCop in sorcery, I can enable the settings. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants