SONARKT-656 Implement S6418: Hard-coded secrets are security-sensitive #625
+547
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leveretka
force-pushed
the
margo/SONARKT-656
branch
from
2f6d111 to
ba436e9
Compare
sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/AbstractHardcodedVisitor.kt
Outdated
Show resolved
Hide resolved
| override fun isSensitiveStringLiteral(value: String): Boolean { | ||
| return value.isNotEmpty() | ||
| && value.length >= MINIMUM_CREDENTIAL_LENGTH | ||
| && getEntropyDetector().hasEnoughEntropy(value) |
There was a problem hiding this comment.
Apparently this condition is always satisfied in the tests. We could optionally add some cases with low-entropy, to increase coverage.
sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/AbstractHardcodedVisitor.kt
Outdated
Show resolved
Hide resolved
sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/AbstractHardcodedVisitor.kt
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSPEC SonarSource/rspec#5124