Skip to content

CPP-6594 S817 Add C++23 context and Unicode string literal examples #5138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

CPP-6594 S817 Add C++23 context and Unicode string literal examples #5138

merged 2 commits into from
Jun 20, 2025

Conversation

michael-jabbour-sonarsource
Copy link
Contributor

@michael-jabbour-sonarsource michael-jabbour-sonarsource commented Jun 18, 2025 •
edited by alejandro-alvarez-sonarsource
Loading

Part of CPP-5486.

  • Add examples with unicode prefixes.
  • Update the rspec based on p2201r1.

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@michael-jabbour-sonarsource michael-jabbour-sonarsource added the cfamily C / C++ / Objective-C label Jun 18, 2025
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title S817 FN with U and u8 wide string literals CPP-6594 S817 FN with U and u8 wide string literals Jun 18, 2025
@michael-jabbour-sonarsource michael-jabbour-sonarsource force-pushed the mj/CPP-5486_mixed_strliteral_prefixes branch from 9eadd09 to 54b70aa Compare June 18, 2025 20:15
@michael-jabbour-sonarsource michael-jabbour-sonarsource force-pushed the mj/CPP-5486_mixed_strliteral_prefixes branch 2 times, most recently from 0f904ab to 7c08dae Compare June 18, 2025 20:33
@alejandro-alvarez-sonarsource
Copy link
Member

alejandro-alvarez-sonarsource commented Jun 19, 2025 •
edited
Loading

I'm not sure about the PR / Jira title, though. I would be more specific about the C++23 change being documented in the rspec. Fixing the FN is a different story, IMHO.

@michael-jabbour-sonarsource michael-jabbour-sonarsource changed the title CPP-6594 S817 FN with U and u8 wide string literals CPP-6594 S817 Add C++23 context and Unicode string literal examples Jun 19, 2025
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@michael-jabbour-sonarsource michael-jabbour-sonarsource added this pull request to the merge queue Jun 20, 2025
Merged via the queue into master with commit 835b756 Jun 20, 2025
10 of 11 checks passed
@michael-jabbour-sonarsource michael-jabbour-sonarsource deleted the mj/CPP-5486_mixed_strliteral_prefixes branch June 20, 2025 08:33
@michael-jabbour-sonarsource michael-jabbour-sonarsource mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandro-alvarez-sonarsource alejandro-alvarez-sonarsource alejandro-alvarez-sonarsource approved these changes

Assignees
No one assigned
Labels
cfamily C / C++ / Objective-C
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-jabbour-sonarsource @alejandro-alvarez-sonarsource