Skip to content

JS-737 [WIP] New key in extra requiredDependency #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2025
Merged

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented Jun 3, 2025

JS-737

On Web squad, we would like to add a new property in the extra field. This field would indicate that this rule should only be applied if the project "uses" this dependency.

Later, we will consume this data and update our Analyzer to make decisions based on this.

Lemme know if you have any comments, otherwise I will continue and update some of our rules where necessary.

@zglicz zglicz added the javascript Pull requests that update Javascript code label Jun 3, 2025
@zglicz zglicz enabled auto-merge June 3, 2025 14:22
Copy link

sonarqube-next bot commented Jun 3, 2025

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Jun 3, 2025

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@zglicz zglicz added this pull request to the merge queue Jun 3, 2025
Merged via the queue into master with commit 6f333f0 Jun 3, 2025
10 of 11 checks passed
@zglicz zglicz deleted the new-key-extra branch June 3, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants