Skip to content

Remove covered_rules.json from master #5101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Conversation

frederic-tingaud-sonarsource
Copy link
Contributor

@frederic-tingaud-sonarsource frederic-tingaud-sonarsource commented Jun 2, 2025

Use the branch `coverage-update` instead
@frederic-tingaud-sonarsource frederic-tingaud-sonarsource added the rspec system Related to handling of rspecs (scripts, doc...) label Jun 2, 2025
Copy link

sonarqube-next bot commented Jun 2, 2025

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Jun 2, 2025

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mpaladin mpaladin changed the title Remove covered_rules.json from master. Remove covered_rules.json from master Jun 2, 2025
@mpaladin mpaladin added this pull request to the merge queue Jun 2, 2025
Merged via the queue into master with commit 870e39e Jun 2, 2025
13 of 15 checks passed
@mpaladin mpaladin deleted the ft/drop-coverage-master branch June 2, 2025 13:12
@michael-jabbour-sonarsource
Copy link
Contributor

@frederic-tingaud-sonarsource It seems that this is causing failures in the dogfood merge (now that both master and dogfood/coverage-update). See https://github.com/SonarSource/rspec/actions/runs/15411659287/job/43364811490.

IDK whether it is best to merge master into dogfood/coverage-update or maybe make dogfood/coverage-update an orphan branch. What do you think?

@mpaladin
Copy link
Contributor

mpaladin commented Jun 3, 2025

@frederic-tingaud-sonarsource It seems that this is causing failures in the dogfood merge (now that both master and dogfood/coverage-update). See https://github.com/SonarSource/rspec/actions/runs/15411659287/job/43364811490.

IDK whether it is best to merge master into dogfood/coverage-update or maybe make dogfood/coverage-update an orphan branch. What do you think?

@michael-jabbour-sonarsource @frederic-tingaud-sonarsource I'll have a look.

@mpaladin
Copy link
Contributor

mpaladin commented Jun 3, 2025

@frederic-tingaud-sonarsource It seems that this is causing failures in the dogfood merge (now that both master and dogfood/coverage-update). See https://github.com/SonarSource/rspec/actions/runs/15411659287/job/43364811490.
IDK whether it is best to merge master into dogfood/coverage-update or maybe make dogfood/coverage-update an orphan branch. What do you think?

@michael-jabbour-sonarsource @frederic-tingaud-sonarsource I'll have a look.

I opened #5108 to update the action.

After removal of covered_rules.json from master the update-coverage action was skipping the push of the branch and leading to merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rspec system Related to handling of rspecs (scripts, doc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants