Skip to content

NET-1484 Modify Rule S3626 to include an exception #5087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

Tim-Pohlmann
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann commented May 27, 2025

NET-1484

Modify Rule S3626 to include an exception about local functions after… return statements

Part of NET-1149

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Modify Rule S3626 to include an exception NET-1484 Modify Rule S3626 to include an exception May 27, 2025
@Tim-Pohlmann Tim-Pohlmann force-pushed the Tim/S3626_AddException branch from 85c1478 to bbff53d Compare May 27, 2025 10:31
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tim-Pohlmann Tim-Pohlmann added this pull request to the merge queue May 27, 2025
Merged via the queue into master with commit 16fd7d7 May 27, 2025
12 of 13 checks passed
@Tim-Pohlmann Tim-Pohlmann deleted the Tim/S3626_AddException branch May 27, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants