Skip to content

SONARARMOR-1147 Modify rules S5146 S5883: Adapt JS compliant example #5084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

SONARARMOR-1147 Modify rules S5146 S5883: Adapt JS compliant example #5084

merged 2 commits into from
May 27, 2025

Conversation

karim-ouerghemmi-sonarsource
Copy link
Contributor

@karim-ouerghemmi-sonarsource karim-ouerghemmi-sonarsource commented May 27, 2025 •
edited by jira bot
Loading

SONARARMOR-1147

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@karim-ouerghemmi-sonarsource karim-ouerghemmi-sonarsource added the javascript Pull requests that update Javascript code label May 27, 2025
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

loris-s-sonarsource
loris-s-sonarsource approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@loris-s-sonarsource loris-s-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karim-ouerghemmi-sonarsource karim-ouerghemmi-sonarsource added this pull request to the merge queue May 27, 2025
Merged via the queue into master with commit 119cfdb May 27, 2025
12 of 13 checks passed
@karim-ouerghemmi-sonarsource karim-ouerghemmi-sonarsource deleted the karim/modify-S5146-5883 branch May 27, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loris-s-sonarsource loris-s-sonarsource loris-s-sonarsource approved these changes

@renaud-tognelli-sonarsource renaud-tognelli-sonarsource Awaiting requested review from renaud-tognelli-sonarsource

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karim-ouerghemmi-sonarsource @loris-s-sonarsource