Skip to content

SONARPY-2864 Create rule S7510 The \"sorted\" function call should not be passed to the \"reversed\" function as an argument #5064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource force-pushed the rule/add-RSPEC-S7510 branch 3 times, most recently from 908ea77 to 1be2262 Compare May 19, 2025 13:52
@maksim-grebeniuk-sonarsource maksim-grebeniuk-sonarsource changed the title Create rule S7510 SONARPY-2864 Create rule S7510 The \"sorted\" function call should not be passed to the \"reversed\" function as an argument May 19, 2025
Copy link
Contributor

@Seppli11 Seppli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've just left a few nit picks

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@Seppli11 Seppli11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for the changes

@joke1196 joke1196 marked this pull request as ready for review June 10, 2025 13:40
@joke1196 joke1196 added this pull request to the merge queue Jun 10, 2025
Merged via the queue into master with commit 9d59b78 Jun 10, 2025
11 of 12 checks passed
@joke1196 joke1196 deleted the rule/add-RSPEC-S7510 branch June 10, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants