Skip to content

DART-246 Modify rule S7409: Add Dart language #5029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 22, 2025
Merged

DART-246 Modify rule S7409: Add Dart language #5029

merged 6 commits into from
May 22, 2025

Conversation

antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented May 8, 2025 •
edited by jira bot
Loading

DART-246

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@antonioaversa antonioaversa marked this pull request as ready for review May 8, 2025 15:56
antonioaversa
antonioaversa commented May 8, 2025
View reviewed changes
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented May 8, 2025

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
0 Dependency risks too severe
0 Vulnerability dependency risks too severe
0 Dependencies with prohibited licenses
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented May 8, 2025

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
0 Dependency risks too severe
0 Vulnerability dependency risks too severe
0 Dependencies with prohibited licenses
No data about Coverage
No data about Duplication

See analysis details on SonarQube

pierre-loup-tristant-sonarsource
pierre-loup-tristant-sonarsource approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed this morning I took care of updating the RSPEC "Recommended Secure Coding Practices" part and "Compliant solution". These changes is based on what I found-out using the Dart PoC of S7409.
(https://sonarsource.atlassian.net/browse/APPSEC-2439).
Please have a quick look to see if you find any typo before merging.

@antonioaversa
Copy link
Contributor Author

@pierre-loup-tristant-sonarsource I think there is a syntactical issue in adoc: https://github.com/SonarSource/rspec/runs/42370694734

@pierre-loup-tristant-sonarsource
Copy link
Contributor

@antonioaversa it should be good now

egon-okerman-sonarsource
egon-okerman-sonarsource approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added some suggested fixes related to the text

@pierre-loup-tristant-sonarsource @egon-okerman-sonarsource
Apply suggestions from code review
a536907 
Co-authored-by: Egon Okerman <egon.okerman@sonarsource.com>
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@antonioaversa antonioaversa added this pull request to the merge queue May 22, 2025
Merged via the queue into master with commit fc82c9b May 22, 2025
8 of 9 checks passed
@antonioaversa antonioaversa deleted the antonio/DART-246-S7409-add-dart-language branch May 22, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource approved these changes

@egon-okerman-sonarsource egon-okerman-sonarsource egon-okerman-sonarsource approved these changes

Assignees
No one assigned
Labels
appsec dart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonioaversa @pierre-loup-tristant-sonarsource @egon-okerman-sonarsource