Skip to content

DART-248 Modify rule S6362: Add Dart language #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented May 7, 2025

DART-248

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@antonioaversa antonioaversa marked this pull request as ready for review May 8, 2025 08:34
Copy link
Contributor

@egon-okerman-sonarsource egon-okerman-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please do add a small note for InAppWebView

class _WebViewPageState extends State<WebViewPage> {
final InAppWebViewController _controller = InAppWebViewController("id", _view)
..setOptions(InAppWebViewGroupOptions(
crossPlatform: InAppWebViewOptions(), // Sensitive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clarify that JS is enabled by default for InAppWebViews

Copy link

sonarqube-next bot commented May 8, 2025

Copy link

sonarqube-next bot commented May 8, 2025

@antonioaversa antonioaversa added this pull request to the merge queue May 21, 2025
Merged via the queue into master with commit 704d486 May 21, 2025
8 of 9 checks passed
@antonioaversa antonioaversa deleted the antonio/DART-248-S6362-add-dart-language branch May 21, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants