-
Notifications
You must be signed in to change notification settings - Fork 31
DART-248 Modify rule S6362: Add Dart language #5016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DART-248 Modify rule S6362: Add Dart language #5016
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please do add a small note for InAppWebView
class _WebViewPageState extends State<WebViewPage> { | ||
final InAppWebViewController _controller = InAppWebViewController("id", _view) | ||
..setOptions(InAppWebViewGroupOptions( | ||
crossPlatform: InAppWebViewOptions(), // Sensitive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please clarify that JS is enabled by default for InAppWebViews
|
|
DART-248
Review
A dedicated reviewer checked the rule description successfully for: