DART-259 Modify rule S6291: Add Dart language #4990
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
egon-okerman-sonarsource
approved these changes
May 5, 2025
| import 'package:sqflite/sqflite.dart'; | ||
|
|
||
| void openDb() async { | ||
| final db = await openDatabase("test.db"); // Noncompliant: no password support |
There was a problem hiding this comment.
Suggested change
| final db = await openDatabase("test.db"); // Noncompliant: no password support | |
| final db = await openDatabase("test.db"); // Sensitive - no password support |
| import 'package:sqflite_sqlcipher/sqflite.dart'; | ||
|
|
||
| void openDb() async { | ||
| final db = await openDatabase("test.db"); // Noncompliant: missing password |
There was a problem hiding this comment.
Suggested change
| final db = await openDatabase("test.db"); // Noncompliant: missing password | |
| final db = await openDatabase("test.db"); // Sensitive - missing password |
| import 'package:sqflite_sqlcipher/sqflite.dart'; | ||
|
|
||
| void openDb() async { | ||
| final db = await openDatabase("test.db", password: "password"); // Compliant |
There was a problem hiding this comment.
Suggested change
| final db = await openDatabase("test.db", password: "password"); // Compliant | |
| final db = await openDatabase("test.db", password: "password"); |
|
Closing this PR since, during investigation work on Firestore, it was determined that the rule may not be relevant anymore in modern code, where Android takes care by default of local DB encryption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DART-259
Review
A dedicated reviewer checked the rule description successfully for: