SonarSource · nicolas-gauthier-sonarsource · May 1, 2025 · May 1, 2025 · May 1, 2025
diff --git a/docs/header_names/allowed_framework_names.adoc b/docs/header_names/allowed_framework_names.adoc
@@ -46,6 +46,7 @@
 * Java JDBC API
 * Java I/O API
 * Java Lang Package
+* Java Logging API
 * Java JNDI API
 * Java Regex API
 * Java XML API

diff --git a/rules/S2091/kotlin/how-to-fix-it/java-xml.adoc b/rules/S2091/kotlin/how-to-fix-it/java-xml.adoc
@@ -13,8 +13,8 @@ import javax.xml.xpath.XPath
 import javax.xml.xpath.XPathConstants
 
 fun authenticate(request: HttpServletRequest, xpath: XPath, doc: Document): Boolean {
-    val user: String = request.getParameter("user")
-    val pass: String = request.getParameter("pass")
+    val user = request.getParameter("user")
+    val pass = request.getParameter("pass")
     val expression = "/users/user[@name='$user' and @pass='$pass']"
     return xpath.evaluate(expression, doc, XPathConstants.BOOLEAN) as Boolean
 }
@@ -28,7 +28,7 @@ import javax.xml.xpath.XPath
 import javax.xml.xpath.XPathConstants
 import javax.xml.xpath.XPathVariableResolver
 
-fun authenticate(request: HttpServletRequest, xpath: XPath, doc: Document?): Boolean {
+fun authenticate(request: HttpServletRequest, xpath: XPath, doc: Document): Boolean {
     val user = request.getParameter("user")
     val pass = request.getParameter("pass")
     val expression = "/users/user[@name=\$user and @pass=\$pass]"

diff --git a/rules/S5145/java/how-to-fix-it/java-se.adoc → ...5145/java/how-to-fix-it/java-logging.adoc b/rules/S5145/java/how-to-fix-it/java-se.adoc → ...5145/java/how-to-fix-it/java-logging.adoc
@@ -1,4 +1,4 @@
-== How to fix it in Java SE
+== How to fix it in Java Logging API
 
 === Code examples
 

diff --git a/rules/S5145/java/rule.adoc b/rules/S5145/java/rule.adoc
@@ -6,7 +6,7 @@ include::../impact.adoc[]
 
 // How to fix it section
 
-include::how-to-fix-it/java-se.adoc[]
+include::how-to-fix-it/java-logging.adoc[]
 
 == Resources
 

diff --git a/...s/S5145/kotlin/how-to-fix-it/java-se.adoc → ...45/kotlin/how-to-fix-it/java-logging.adoc b/...s/S5145/kotlin/how-to-fix-it/java-se.adoc → ...45/kotlin/how-to-fix-it/java-logging.adoc
@@ -1,4 +1,4 @@
-== How to fix it in Java SE
+== How to fix it in Java Logging API
 
 === Code examples
 

diff --git a/rules/S5145/kotlin/rule.adoc b/rules/S5145/kotlin/rule.adoc
@@ -4,7 +4,7 @@ include::../rationale.adoc[]
 
 include::../impact.adoc[]
 
-include::how-to-fix-it/java-se.adoc[]
+include::how-to-fix-it/java-logging.adoc[]
 
 == Resources
 

diff --git a/rules/S6384/java/rule.adoc b/rules/S6384/java/rule.adoc
@@ -20,15 +20,7 @@ ifdef::env-github,rspecator-view[]
 == Implementation Specification
 (visible only on this page)
 
-=== Message
-
-Change this code to not perform arbitrary intent redirection.
-
+include::../message.adoc[]
 
 endif::env-github,rspecator-view[]
 
-'''
-== Implementation Specification
-(visible only on this page)
-
-include::../message.adoc[]
diff --git a/rules/S6384/kotlin/rule.adoc b/rules/S6384/kotlin/rule.adoc
@@ -20,15 +20,8 @@ ifdef::env-github,rspecator-view[]
 == Implementation Specification
 (visible only on this page)
 
-=== Message
-
-Change this code to not perform arbitrary intent redirection.
+include::../message.adoc[]
 
 
 endif::env-github,rspecator-view[]
 
-'''
-== Implementation Specification
-(visible only on this page)
-
-include::../message.adoc[]
diff --git a/rules/S6390/java/how-to-fix-it/java-se.adoc → ...s/S6390/java/how-to-fix-it/java-lang.adoc b/rules/S6390/java/how-to-fix-it/java-se.adoc → ...s/S6390/java/how-to-fix-it/java-lang.adoc
@@ -1,4 +1,4 @@
-== How to fix it in Java SE
+== How to fix it in Java Lang Package
 
 === Code examples
 

diff --git a/rules/S6390/java/rule.adoc b/rules/S6390/java/rule.adoc
@@ -24,7 +24,7 @@ might badly answer, be slowed down, or become completely irresponsive.
 
 // How to fix it section
 
-include::./how-to-fix-it/java-se.adoc[]
+include::./how-to-fix-it/java-lang.adoc[]
 
 == Resources
 

diff --git a/...s/S6390/kotlin/how-to-fix-it/java-se.adoc → ...S6390/kotlin/how-to-fix-it/java-lang.adoc b/...s/S6390/kotlin/how-to-fix-it/java-se.adoc → ...S6390/kotlin/how-to-fix-it/java-lang.adoc
@@ -1,4 +1,4 @@
-== How to fix it in Java SE
+== How to fix it in Java Lang Package
 
 === Code examples
 

diff --git a/rules/S6390/kotlin/rule.adoc b/rules/S6390/kotlin/rule.adoc
@@ -24,7 +24,7 @@ might badly answer, be slowed down, or become completely irresponsive.
 
 // How to fix it section
 
-include::./how-to-fix-it/java-se.adoc[]
+include::./how-to-fix-it/java-lang.adoc[]
 
 == Resources
 

diff --git a/rules/S6547/java/how-to-fix-it/java-se.adoc → ...s/S6547/java/how-to-fix-it/java-lang.adoc b/rules/S6547/java/how-to-fix-it/java-se.adoc → ...s/S6547/java/how-to-fix-it/java-lang.adoc
@@ -1,4 +1,4 @@
-== How to fix it in Java SE
+== How to fix it in Java Lang Package
 
 === Code examples
 

diff --git a/rules/S6547/java/rule.adoc b/rules/S6547/java/rule.adoc
@@ -6,7 +6,7 @@ include::../impact.adoc[]
 
 // How to fix it section
 
-include::how-to-fix-it/java-se.adoc[]
+include::how-to-fix-it/java-lang.adoc[]
 
 == Resources
 

diff --git a/...s/S6547/kotlin/how-to-fix-it/java-se.adoc → ...S6547/kotlin/how-to-fix-it/java-lang.adoc b/...s/S6547/kotlin/how-to-fix-it/java-se.adoc → ...S6547/kotlin/how-to-fix-it/java-lang.adoc
@@ -1,4 +1,4 @@
-== How to fix it in Java SE
+== How to fix it in Java Lang Package
 
 === Code examples
 

diff --git a/rules/S6547/kotlin/rule.adoc b/rules/S6547/kotlin/rule.adoc
@@ -6,7 +6,7 @@ include::../impact.adoc[]
 
 // How to fix it section
 
-include::how-to-fix-it/java-se.adoc[]
+include::how-to-fix-it/java-lang.adoc[]
 
 == Resources