Modify rule S4790: Add Dart language #4980
Conversation
antonioaversa
force-pushed
the
antonio/DART-250-S4790-add-dart-language
branch
from
a72fd49 to
e13bcb3
Compare
antonioaversa
force-pushed
the
antonio/DART-250-S4790-add-dart-language
branch
from
e13bcb3 to
3fe1b08
Compare
rules/S4790/dart/rule.adoc
Outdated
| ---- | ||
| import 'package:crypto/crypto.dart'; | ||
|
|
||
| final digest = sha1.convert(input).bytes; // Noncompliant |
There was a problem hiding this comment.
| final digest = sha1.convert(input).bytes; // Noncompliant | |
| final digest = sha1.convert(input).bytes; // Sensitive |
rules/S4790/dart/rule.adoc
Outdated
| ---- | ||
| import 'package:pointycastle/export.dart'; | ||
|
|
||
| final digest = Digest('SHA-1'); // Noncompliant |
There was a problem hiding this comment.
| final digest = Digest('SHA-1'); // Noncompliant | |
| final digest = Digest('SHA-1'); // Sensitive |
rules/S4790/dart/rule.adoc
Outdated
| ---- | ||
| import 'package:cryptography/cryptography.dart'; | ||
|
|
||
| final digest = Sha1(); // Noncompliant |
There was a problem hiding this comment.
| final digest = Sha1(); // Noncompliant | |
| final digest = Sha1(); // Sensitive |
There was a problem hiding this comment.
LGTM.
Reading SonarSource/sonar-dotnet#9180 (comment) I realize the description.adoc part is confusing because it mix Hash ans MAC algorithm in the same list.
I created #5007 to improve the text. The rule probably deserve even better content but I don't want to spend time on this today.
We can merge the change on this branch or on master. I let you decide.
Indeed. I merged into this PR, so that we have a single PR to merge onto |
|
|
Review
A dedicated reviewer checked the rule description successfully for: