-
Notifications
You must be signed in to change notification settings - Fork 31
DART-247 Modify rule S4830: Add Dart language #4978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DART-247 Modify rule S4830: Add Dart language #4978
Conversation
49dd5e5
to
3b51ef3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have a look at the improvement suggestion I made before merging.
include::../../common/fix/code-rationale.adoc[] | ||
|
||
:cert_method_name: badCertificateCallback | ||
|
||
include::../../common/fix/code-rationale-override.adoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part could be improved:
include::../../common/fix/code-rationale.adoc[] | |
:cert_method_name: badCertificateCallback | |
include::../../common/fix/code-rationale-override.adoc[] | |
The certificate validation gets disabled by implementing a `badCertificateCallback` that always return `true`. It is highly recommended to use the original implementation and to avoid any bypass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, "empty" is not exact as the callback actually has a return true
, at very least, in the case of Dart.
Unlike in the suggestion above, I have kept the include::../../common/fix/code-rationale.adoc[]
(The following code contains examples of disabled certificate validation.
), since it still applies to Dart as to any other language, and also to keep the languages as aligned as possible.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DART-247
Review
A dedicated reviewer checked the rule description successfully for: