Skip to content

Modify rule S6649: Add exceptions for x / 0 #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GabrielFleischer
Copy link
Contributor

If the user writes 1 / 0, this is not a mistake

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

If the user writes 1 / 0, this is not a mistake
@GabrielFleischer GabrielFleischer changed the title Modify rule S6649ö Add exceptions for 1 / 0 Modify rule S6649: Add exceptions for x / 0 Apr 23, 2025
Copy link
Contributor

@Swalkyn Swalkyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry I forgot this was assigned to me...

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@GabrielFleischer GabrielFleischer added this pull request to the merge queue Apr 28, 2025
Merged via the queue into master with commit e37d0a3 Apr 28, 2025
8 of 9 checks passed
@GabrielFleischer GabrielFleischer deleted the gfleischer/add-exception-to-volontary-failure-S6649 branch April 28, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants