Skip to content

Modify S1135: remove flex #4704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Modify S1135: remove flex #4704

merged 1 commit into from
Feb 27, 2025

Conversation

kebetsi
Copy link
Contributor

@kebetsi kebetsi commented Feb 25, 2025

We haven't implemented it, and we surely won't now: https://sonarsource.github.io/rspec/#/rspec/S1135/flex

@kebetsi kebetsi requested a review from vdiez February 25, 2025 08:07
@kebetsi kebetsi added the flex label Feb 25, 2025
@kebetsi kebetsi enabled auto-merge (squash) February 25, 2025 08:10
@kebetsi kebetsi disabled auto-merge February 25, 2025 12:25
@kebetsi kebetsi force-pushed the remove-flex-from-S1135 branch from de700b6 to e40da83 Compare February 25, 2025 12:27
@kebetsi kebetsi enabled auto-merge (squash) February 25, 2025 12:32
@kebetsi
Copy link
Contributor Author

kebetsi commented Feb 25, 2025

I have no idea why the [rspec-tools] SonarQube Code Analysis check fails nor how to relaunch it without doing a rebase...

@vdiez vdiez force-pushed the remove-flex-from-S1135 branch from e40da83 to a7f734d Compare February 27, 2025 08:06
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kebetsi kebetsi merged commit 8b10fbc into master Feb 27, 2025
8 of 9 checks passed
@kebetsi kebetsi deleted the remove-flex-from-S1135 branch February 27, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants