Skip to content

Remove default severity #4674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Remove default severity #4674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6e83b2
Fix discrepencies between MQR and severity for CFamily rules
frederic-tingaud-sonarsource Feb 18, 2025
f24fac5
Remove defaultSeverity from all json files
frederic-tingaud-sonarsource Feb 19, 2025
dc3f77f
Remove defaultSeverity from the schema
frederic-tingaud-sonarsource Feb 19, 2025
a27c13b
Change frontend to use code impacts for severity
frederic-tingaud-sonarsource Feb 19, 2025
b44ed7c
Fix tests and severity display
frederic-tingaud-sonarsource Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
190 changes: 158 additions & 32 deletions frontend/src/__tests__/__snapshots__/RulePage.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,6 +847,61 @@ var res = string.Format("{0} {1}", array); // Compliant we don't know the size o
</span>
,

<span
class="hljs-attr"
>
"code"
</span>
: {

<span
class="hljs-attr"
>
"impacts"
</span>
: {

<span
class="hljs-attr"
>
"MAINTAINABILITY"
</span>
:
<span
class="hljs-string"
>
"MEDIUM"
</span>

},

<span
class="hljs-attr"
>
"attribute"
</span>
:
<span
class="hljs-string"
>
"CLEAR"
</span>

},

<span
class="hljs-attr"
>
"severity"
</span>
:
<span
class="hljs-string"
>
"MEDIUM"
</span>
,

<span
class="hljs-attr"
>
Expand Down Expand Up @@ -939,19 +994,6 @@ var res = string.Format("{0} {1}", array); // Compliant we don't know the size o
</span>
,

<span
class="hljs-attr"
>
"defaultSeverity"
</span>
:
<span
class="hljs-string"
>
"Major"
</span>
,

<span
class="hljs-attr"
>
Expand Down Expand Up @@ -1887,6 +1929,48 @@ exports[`renders cfamily version of S1000 1`] = `
</span>
,

<span
class="hljs-attr"
>
"code"
</span>
: {

<span
class="hljs-attr"
>
"impacts"
</span>
: {

<span
class="hljs-attr"
>
"MAINTAINABILITY"
</span>
:
<span
class="hljs-string"
>
"MEDIUM"
</span>

},

<span
class="hljs-attr"
>
"attribute"
</span>
:
<span
class="hljs-string"
>
"CLEAR"
</span>

},

<span
class="hljs-attr"
>
Expand Down Expand Up @@ -1990,39 +2074,39 @@ exports[`renders cfamily version of S1000 1`] = `
<span
class="hljs-attr"
>
"defaultSeverity"
"ruleSpecification"
</span>
:
<span
class="hljs-string"
>
"Major"
"RSPEC-1000"
</span>
,

<span
class="hljs-attr"
>
"ruleSpecification"
"sqKey"
</span>
:
<span
class="hljs-string"
>
"RSPEC-1000"
"UnnamedNamespaceInHeader"
</span>
,

<span
class="hljs-attr"
>
"sqKey"
"severity"
</span>
:
<span
class="hljs-string"
>
"UnnamedNamespaceInHeader"
"MEDIUM"
</span>
,

Expand Down Expand Up @@ -3561,6 +3645,61 @@ var res = string.Format("{0} {1}", array); // Compliant we don't know the size o
</span>
,

<span
class="hljs-attr"
>
"code"
</span>
: {

<span
class="hljs-attr"
>
"impacts"
</span>
: {

<span
class="hljs-attr"
>
"MAINTAINABILITY"
</span>
:
<span
class="hljs-string"
>
"MEDIUM"
</span>

},

<span
class="hljs-attr"
>
"attribute"
</span>
:
<span
class="hljs-string"
>
"CLEAR"
</span>

},

<span
class="hljs-attr"
>
"severity"
</span>
:
<span
class="hljs-string"
>
"MEDIUM"
</span>
,

<span
class="hljs-attr"
>
Expand Down Expand Up @@ -3653,19 +3792,6 @@ var res = string.Format("{0} {1}", array); // Compliant we don't know the size o
</span>
,

<span
class="hljs-attr"
>
"defaultSeverity"
</span>
:
<span
class="hljs-string"
>
"Major"
</span>
,

<span
class="hljs-attr"
>
Expand Down
8 changes: 7 additions & 1 deletion frontend/src/deployment/__tests__/resources/metadata/S1000/cfamily-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
"type": "CODE_SMELL",
"status": "ready",
"quickfix": "unknown",
"code": {
"impacts": {
"MAINTAINABILITY": "MEDIUM"
},
"attribute": "CLEAR"
},
"remediation": {
"func": "Constant/Issue",
"constantCost": "1h"
Expand All @@ -19,9 +25,9 @@
],
"replacementRules": []
},
"defaultSeverity": "Major",
"ruleSpecification": "RSPEC-1000",
"sqKey": "UnnamedNamespaceInHeader",
"severity": "MEDIUM",
"scope": "Main",
"securityStandards": {
"CERT": [
Expand Down
8 changes: 7 additions & 1 deletion frontend/src/deployment/__tests__/resources/metadata/S1000/default-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@
"func": "Constant/Issue",
"constantCost": "1h"
},
"code": {
"impacts": {
"MAINTAINABILITY": "MEDIUM"
},
"attribute": "CLEAR"
},
"tags": [
"cert",
"misra-c++2008",
Expand All @@ -18,9 +24,9 @@
"UnnamedNamespaceInHeader"
]
},
"defaultSeverity": "Major",
"ruleSpecification": "RSPEC-1000",
"sqKey": "UnnamedNamespaceInHeader",
"severity": "MEDIUM",
"scope": "Main",
"securityStandards": {
"CERT": [
Expand Down
8 changes: 7 additions & 1 deletion frontend/src/deployment/__tests__/resources/metadata/S3457/cfamily-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
"title": "Printf-style format strings should be used correctly",
"type": "CODE_SMELL",
"status": "ready",
"code": {
"impacts": {
"MAINTAINABILITY": "MEDIUM"
},
"attribute": "CLEAR"
},
"remediation": {
"func": "Constant\/Issue",
"constantCost": "10min"
Expand All @@ -18,7 +24,6 @@
"S3457"
],
"branch": "master",
"defaultSeverity": "Minor",
"extra": {
"legacyKeys": [],
"replacementRules": []
Expand All @@ -32,6 +37,7 @@
"FIO47-C."
]
},
"severity": "MEDIUM",
"languagesSupport": [
{
"name": "cfamily",
Expand Down
8 changes: 7 additions & 1 deletion frontend/src/deployment/__tests__/resources/metadata/S3457/csharp-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
"title": "Composite format strings should be used correctly",
"type": "CODE_SMELL",
"status": "ready",
"code": {
"impacts": {
"MAINTAINABILITY": "MEDIUM"
},
"attribute": "CLEAR"
},
"severity": "MEDIUM",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "10min"
Expand All @@ -16,7 +23,6 @@
"S3457"
],
"branch": "master",
"defaultSeverity": "Major",
"extra": {
"legacyKeys": [],
"replacementRules": []
Expand Down
8 changes: 7 additions & 1 deletion frontend/src/deployment/__tests__/resources/metadata/S3457/default-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
"title": "Printf-style format strings should be used correctly",
"type": "CODE_SMELL",
"status": "ready",
"code": {
"impacts": {
"MAINTAINABILITY": "MEDIUM"
},
"attribute": "CLEAR"
},
"severity": "MEDIUM",
"remediation": {
"func": "Constant/Issue",
"constantCost": "10min"
Expand All @@ -15,7 +22,6 @@
"replacementRules": [],
"legacyKeys": []
},
"defaultSeverity": "Minor",
"ruleSpecification": "RSPEC-3457",
"sqKey": "S3457",
"scope": "All",
Expand Down
Loading