Skip to content

CPP-6162 S1265 Require sized delete since C++14 and definitions in the same file #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 26, 2025
Merged

CPP-6162 S1265 Require sized delete since C++14 and definitions in the same file #4672

merged 3 commits into from
Feb 26, 2025

Conversation

michael-jabbour-sonarsource
Copy link
Contributor

@michael-jabbour-sonarsource michael-jabbour-sonarsource commented Feb 19, 2025 •
edited by jira bot
Loading

CPP-6162

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@michael-jabbour-sonarsource michael-jabbour-sonarsource changed the title CPP-6162 S1265 Require sized delete since C++14 and definitions in th… CPP-6162 S1265 Require sized delete since C++14 and definitions in the same file Feb 19, 2025
@michael-jabbour-sonarsource michael-jabbour-sonarsource added the cfamily C / C++ / Objective-C label Feb 19, 2025
@michael-jabbour-sonarsource michael-jabbour-sonarsource marked this pull request as ready for review February 25, 2025 10:44
mostafa-mohammed-sonarsource
mostafa-mohammed-sonarsource approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mostafa-mohammed-sonarsource mostafa-mohammed-sonarsource merged commit 99e38a9 into master Feb 26, 2025
8 of 9 checks passed
@mostafa-mohammed-sonarsource mostafa-mohammed-sonarsource deleted the mj/CPP-6162_S1265_FNs branch February 26, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mostafa-mohammed-sonarsource mostafa-mohammed-sonarsource mostafa-mohammed-sonarsource approved these changes

Assignees
No one assigned
Labels
cfamily C / C++ / Objective-C
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michael-jabbour-sonarsource @mostafa-mohammed-sonarsource