CPP-6157 Fix discrepancies between MQR and severity for CFamily rules #4669
Conversation
frederic-tingaud-sonarsource
changed the title
loic-joly-sonarsource
changed the title
| @@ -17,7 +17,7 @@ | |||
| "quickfix": "infeasible", | |||
| "code": { | |||
| "impacts": { | |||
| "MAINTAINABILITY": "HIGH" | |||
| "MAINTAINABILITY": "MEDIUM" | |||
There was a problem hiding this comment.
HIGH seems ok for me here. I really don't understand the fact that HIGH and CRITICAL are related. Or to say in another way, in non-MQR mode, the names cover a 2 dimension design space, while in MQR mode, they convey a single dimension scale...
Anyways, I think there is a high impact / low likelihood risk there, in the case where the mutex is not locked.
There was a problem hiding this comment.
I put it as MEDIUM because I disagree with the mutex not locked case: creating an unnamed lock would be exactly the same bug outside an if and we already catch it with S5184
Co-authored-by: Loïc Joly <loic.joly@sonarsource.com>
|
|
We noticed multiple discrepancies between MQR and defaultSeverity. This PR fixes those on CFamily-specific rules