Skip to content

RULEAPI-832 Automatically migrate all rules where defaultSeverity is "Blocker" but MQR is only "High" #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

frederic-tingaud-sonarsource
Copy link
Contributor

Multiple qualities:
{'common': ['S1523', 'S2077', 'S5973', 'S6793', 'S6807', 'S6811', 'S6821', 'S6822', 'S6824', 'S6827', 'S6840', 'S6841', 'S6842', 'S6843', 'S6844', 'S6845', 'S6846', 'S6847', 'S6848', 'S6850', 'S6851', 'S6852', 'S6867', 'S6868', 'S6967'], 'xml': ['S3281', 'S3355'], 'cfamily': ['S5782', 'S6991', 'S7012', 'S7038', 'S7042', 'S7119', 'S7132'], 'python': ['S6709', 'S6714', 'S6727', 'S6729', 'S6734', 'S6740', 'S6741', 'S6882', 'S6883', 'S6887', 'S6890', 'S6894', 'S6900', 'S6903', 'S6919', 'S6925', 'S6928', 'S6929', 'S6971', 'S6973', 'S6974', 'S6982'], 'javascript': ['S6746', 'S6747', 'S6748', 'S6750', 'S6756', 'S6757', 'S6761', 'S6763', 'S6766', 'S6772', 'S6774', 'S6788', 'S6789', 'S6790', 'S6791', 'S6859', 'S6861', 'S7059', 'S7060'], 'java': ['S6804', 'S6806', 'S6813', 'S6818', 'S6829', 'S6831'], 'kubernetes': ['S6865', 'S6869', 'S6870', 'S6873', 'S6892', 'S6897', 'S6907'], 'csharp': ['S6932'], 'docker': ['S7019', 'S7023', 'S7029', 'S7030']}

Contradiction between quality and severity, please migrate manually:
{'javascript': ['S5254'], 'java': ['S6485', 'S6809', 'S6814', 'S6816', 'S6817', 'S6830', 'S6837', 'S6857', 'S6863', 'S6876', 'S6877', 'S6878', 'S6881', 'S6889', 'S6891', 'S6898', 'S6904', 'S6905', 'S6909', 'S6912', 'S6914', 'S6923', 'S6926', 'S7027', 'S7091'], 'common': ['S6582', 'S6620', 'S6680', 'S6819', 'S6823', 'S6853', 'S7044', 'S7071', 'S7131', 'S7133', 'S7134'], 'python': ['S6660'], 'cfamily': ['S6936', 'S6996', 'S7032', 'S7040', 'S7127'], 'text': ['S7036']}

Migrated:
{'common': ['S1133', 'S1135', 'S2076', 'S2078', 'S2083', 'S2091', 'S2115', 'S2755', 'S3649', 'S3688', 'S4647', 'S5131', 'S5135', 'S5146', 'S5147', 'S5334', 'S5696', 'S6096', 'S6105', 'S6384', 'S6437'], 'python': ['S2159'], 'secrets': ['S6784', 'S7136', 'S7137', 'S7138', 'S7139', 'S7140', 'S7141', 'S7142', 'S7143', 'S7144', 'S7145', 'S7146', 'S7147', 'S7148', 'S7149', 'S7150', 'S7151', 'S7152', 'S7153', 'S7154', 'S7155', 'S7159', 'S7161', 'S7162', 'S7163', 'S7164', 'S7165', 'S7166', 'S7167', 'S7169', 'S7170', 'S7171', 'S7174', 'S7175']}

@frederic-tingaud-sonarsource frederic-tingaud-sonarsource changed the title Automatically migrate all rules where defaultSeverity is Blocker and MQR is High RULEAPI-832 Automatically migrate all rules where defaultSeverity is "Blocker" but MQR is only "High" Feb 18, 2025
Copy link
Contributor

@nils-werner-sonarsource nils-werner-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have two questions regarding impacts aside from "Blocker"

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@frederic-tingaud-sonarsource frederic-tingaud-sonarsource merged commit 972b0e3 into master Feb 20, 2025
8 of 9 checks passed
@frederic-tingaud-sonarsource frederic-tingaud-sonarsource deleted the ft/missed-migration branch February 20, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants