Skip to content

Fix coverage script when there is no new coverage #4089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

frederic-tingaud-sonarsource
Copy link
Contributor

@frederic-tingaud-sonarsource frederic-tingaud-sonarsource commented Jul 23, 2024

The previous change to the task 'Push the updated coverage to master' made it passthrough because it used {{ as part of the condition, which seems to be forbidden.
Changing the condition to what we usually use to check default_branch in other workflow scripts throughout our repositories.

@frederic-tingaud-sonarsource frederic-tingaud-sonarsource added the rspec system Related to handling of rspecs (scripts, doc...) label Jul 23, 2024
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@necto
Copy link
Contributor

necto commented Jul 23, 2024

Please don't forget to add some explanation in the commit message

@frederic-tingaud-sonarsource frederic-tingaud-sonarsource merged commit a20a456 into master Jul 23, 2024
12 of 13 checks passed
@frederic-tingaud-sonarsource frederic-tingaud-sonarsource deleted the ft/nochange branch July 23, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rspec system Related to handling of rspecs (scripts, doc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants