Skip to content

Modify rule S6909: Fix errors in code examples #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Modify rule S6909: Fix errors in code examples #4008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions rules/S6909/java/rule.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class DatabaseExample {
public void updateTodayOrders(Connection connection, List<Order> orders) {
Date today = java.sql.Date.valueOf(LocalDate.now());
String insertQuery = "INSERT INTO Order (id, price, executionDate) VALUES (?, ?, ?)";
PreparedStatement preparedStatement = connection.prepareStatement(SQL_INSERT);
PreparedStatement preparedStatement = connection.prepareStatement(insertQuery);

for(Order order: orders) {
preparedStatement.setString(1, order.id());
Expand All @@ -50,10 +50,9 @@ public class DatabaseExample {
public void updateTodayOrders(Connection connection, List<Order> orders) {
Date today = java.sql.Date.valueOf(LocalDate.now());
String insertQuery = "INSERT INTO Order (id, price, executionDate) VALUES (?, ?, ?)";
preparedStatement.setDate(3, today); // Compliant

PreparedStatement preparedStatement = connection.prepareStatement(SQL_INSERT);
PreparedStatement preparedStatement = connection.prepareStatement(insertQuery);

preparedStatement.setDate(3, today); // Compliant
for(Order order: orders) {
preparedStatement.setString(1, order.id());
preparedStatement.setString(2, order.price());
Expand Down