Skip to content

Modify rule S6929: add the PyTorch library #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Conversation

ghislainpiot
Copy link
Contributor

No description provided.

Copy link
Contributor

@joke1196 joke1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I think you need to provide as well the code example for the Tensorflow. As in SonarQube the how to fix it in is a tab.

Comment on lines 74 to 77
== How to fix it in PyTorch

To fix this issue provide the dim argument when using a PyTorch reduction operation such as ``torch.sum``, ``torch.prod``, ``torch.mean``, etc...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think you need to provide === Code examples for PyTorch. and add another Code example section under Tensorflow.

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ghislainpiot ghislainpiot requested a review from joke1196 June 10, 2024 09:55
Copy link
Contributor

@joke1196 joke1196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All works nicely in SQ.

@joke1196 joke1196 marked this pull request as ready for review September 27, 2024 10:17
@joke1196 joke1196 merged commit b9b85c7 into master Sep 27, 2024
10 of 11 checks passed
@joke1196 joke1196 deleted the gp/s6929-pytorch branch September 27, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants