-
Notifications
You must be signed in to change notification settings - Fork 31
Modify rule S6929: add the PyTorch library #3984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d315116
to
2a01c52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but I think you need to provide as well the code example for the Tensorflow. As in SonarQube the how to fix it in is a tab.
rules/S6929/python/rule.adoc
Outdated
== How to fix it in PyTorch | ||
|
||
To fix this issue provide the dim argument when using a PyTorch reduction operation such as ``torch.sum``, ``torch.prod``, ``torch.mean``, etc... | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I think you need to provide === Code examples
for PyTorch. and add another Code example section under Tensorflow.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! All works nicely in SQ.
No description provided.