Create rule S6983 #3973
Create rule S6983 #3973
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghislainpiot
force-pushed
the
rule/add-RSPEC-S6983
branch
from
735aa81 to
e1e5ce0
Compare
| == Why is this an issue? | ||
|
|
||
| In the PyTorch library, the data loaders are used to provide an interface where common operations such as batching can be implemented. | ||
| It is also possible to parallelize the data loading process by using multiple worker processes. |
There was a problem hiding this comment.
Not 100% sure here but I think worker should plurialized
There was a problem hiding this comment.
I think it should not be pluralized
rules/S6983/python/rule.adoc
Outdated
|
|
||
| In the PyTorch library, the data loaders are used to provide an interface where common operations such as batching can be implemented. | ||
| It is also possible to parallelize the data loading process by using multiple worker processes. | ||
| This can increase performance by increasing the number of batches being fetched in parallel, at the cost of higher memory usage. |
There was a problem hiding this comment.
Here, to remove repetition, I would go with This can improve performance...
rules/S6983/python/metadata.json
Outdated
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "title": "The \"nb_workers\" parameter should be specified for `torch.utils.data.DataLoader`", | |||
There was a problem hiding this comment.
I think this should be num_workers instead?
rules/S6983/python/metadata.json
Outdated
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "title": "The \"num_workers\" parameter should be specified for `torch.utils.data.DataLoader`", | |||
There was a problem hiding this comment.
I just caught that sorry, but we should not use backticks in titles.
There was a problem hiding this comment.
You forgot to remove the backticks
|
|
Seppli11
force-pushed
the
rule/add-RSPEC-S6983
branch
from
dead7f6 to
02630aa
Compare
|
|
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: