-
Notifications
You must be signed in to change notification settings - Fork 31
Create rule S6979 #3959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rule S6979 #3959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Just added a small suggestion for clarity.
rules/S6979/python/rule.adoc
Outdated
|
||
== Why is this an issue? | ||
|
||
The Pytorch Variable API has been deprecated. Autograd now works as expected with tensors that have the `requires_grad` attribute set to `True`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this second sentence. I think it would be clearer to say that the behaviour of Variable comes out of the box when using tensors and setting requires_grad to True. As opposed to cite how Autograd works.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
|
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: