JS-822 Enable type-checking for single-file analysis #5860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zglicz
approved these changes
Oct 30, 2025
| program, | ||
| ...fieldsForJsTsAnalysisInput(), | ||
| }); | ||
| pendingFiles.delete(fileName); |
There was a problem hiding this comment.
I don't like this passing in a structure, mutating it as we iterate over it. Can we have another structure for "completed" files, so that when we loop through pending files, we just check if its in the completed set of files?
| if (isAnalysisCancelled()) { | ||
| return; | ||
| } | ||
| if (!pendingFiles.has(pendingFile) || !files[pendingFile]) { |
There was a problem hiding this comment.
how can a file be in pendingFiles and not int files? If that is possible, shouldn't we first filter the pendingFiles by the files object?
Comment on lines
-17
to
-21
| import { JsTsAnalysisInput, JsTsAnalysisOutput, JsTsAnalysisOutputWithAst } from '../analysis.js'; | ||
| import { RuleConfig } from '../../linter/config/rule-config.js'; | ||
| import { EmbeddedAnalysisOutput } from '../../embedded/analysis/analysis.js'; | ||
| import { ErrorCode } from '../../../../shared/src/errors/error.js'; | ||
| import { Configuration } from '../../../../shared/src/helpers/configuration.js'; |
There was a problem hiding this comment.
ehhh, we really should add this rule into SQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS-822