Skip to content

fix: register an agent after tool validation #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: register an agent after tool validation #523

wants to merge 3 commits into from

Conversation

@alimosaed
Copy link
Collaborator

@alimosaed alimosaed commented Nov 7, 2025

Goal:

  • SAM loads agents even if a tool fails. This makes confusion because the agent is up but the tools are unavailable.
  • If a MCP server runs locally and the directory is unavailable, the tool fails without an informative log.

Changes:

  • Reordered the agent registration to ensure that an agent is registered after tool validation.
  • Added some exception handling and logs to catch MCP server failures.

What should reviewers pay attention to?

  • The edge cases

@sonarqube-solacecloud
Copy link

sonarqube-solacecloud bot commented Nov 7, 2025

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efunneko efunneko Awaiting requested review from efunneko

@gregmeldrum gregmeldrum Awaiting requested review from gregmeldrum

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alimosaed