fix(DATAGO-116434): session id passing and clearing messages. #504
+25
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteSource Policy Violation Summary✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-ui-pr-504! |
lgh-solace
commented
Nov 4, 2025
| }, | ||
| [sessionId] | ||
| ); | ||
| const deserializeTaskToMessages = useCallback((task: { taskId: string; messageBubbles: any[]; taskMetadata?: any; createdTime: number }, targetSessionId: string): MessageFE[] => { |
Collaborator
Author
There was a problem hiding this comment.
Passing in targetSessionId to avoid using a stale id.
| setSessionId(newSessionId); | ||
|
|
||
| // Clear messages IMMEDIATELY after updating sessionId | ||
| setMessages([]); |
Collaborator
Author
There was a problem hiding this comment.
Moving this down.
lgh-solace
commented
Nov 4, 2025
| isError: bubble.isError, | ||
| metadata: { | ||
| messageId: bubble.id, | ||
| sessionId: targetSessionId, |
Collaborator
Author
There was a problem hiding this comment.
Note: all the formatting changes here are due to my workspace settings - the functional changes are small (just passing the id and moving the clearing of messages).
lgh-solace
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily refactors and improves the
ChatProvidercomponent inChatProvider.tsx, focusing on session management, code clarity, and consistent state updates. The most significant changes ensure that session switching is more reliable, deserialization of messages is more robust, and code formatting is cleaner throughout the file.Session Management Improvements:
sessionIdbefore clearing messages, ensuring all dependent components/hooks receive the correct session context and preventing display of stale messages. The clearing of messages is now performed immediately after updating the session ID, and other session-related state is reset accordingly. [1] [2]Message Deserialization and State Consistency:
deserializeTaskToMessagesfunction to accept atargetSessionIdparameter, ensuring that messages are always associated with the correct session, and updated all usages accordingly. [1] [2] [3]Code Formatting and Readability:
Callback and Dependency List Cleanups:
useCallbackhooks, ensuring consistent formatting and reducing the risk of dependency-related bugs. [1] [2]Minor Consistency Fixes:
These changes collectively improve the robustness of session handling, reduce the risk of stale or inconsistent UI state, and make the codebase easier to read and maintain.