fix(DATAGO-114474): Avoid reconfiguring logging when Alembic migration takes place #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n takes place Fixes logging reconfiguration issue during Alembic database migrations that was overriding the application's logging configuration. Changes: - Removed logging configuration from alembic.ini: Deleted the [loggers], [handlers], and [formatters] sections that were defining custom logging behavior for Alembic - Updated env.py: Removed the fileConfig() call that was loading and applying the Alembic logging configuration from the config file This prevents Alembic from reconfiguring the Python logging system and overriding the application's existing logging setup during migrations. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
WhiteSource Policy Violation Summary✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-pr-400! |
mo-radwan1
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes logging reconfiguration issue during Alembic database migrations that was overriding the application's logging configuration.
Changes
Problem
When Alembic migrations execute, they would reconfigure the Python logging system using their own configuration from alembic.ini. This would override the application's existing logging setup, causing unexpected loss of properly configured loggers and changes in log formatting.
Related
This fix mirrors the changes made in SolaceDev/solace-agent-mesh-enterprise#208 which addressed the same issue in the enterprise repository.