refactor: change private properties to protected for extensibility #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for building AdminJS!
I ran into a little snag when trying to extend some of the Prisma resource functionalities, specifically with the
buildSortBy
,model
... properties being private:Having this method as private means a lot of repeating code if we try to customize behavior. It would be awesome if it could be switched to protected to make subclassing a breeze and keep our codebase clean.
Thought this might make AdminJS more flexible for others too who might be looking to extend functionality in similar ways.
Thanks for considering this tweak!