Add Lightspeed Reatail provider #1373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atymic
reviewed
Jul 16, 2025
src/LightspeedRetail/Provider.php
Outdated
| { | ||
| const IDENTIFIER = 'LIGHTSPEEDRETAIL'; | ||
|
|
||
| protected $scopes = ['']; |
Member
There was a problem hiding this comment.
Can we just leave this as an empty array please?
src/LightspeedRetail/Provider.php
Outdated
| )); | ||
|
|
||
| // Store domain prefix with the user | ||
| $user->domainPrefix = $this->domainPrefix; |
Member
There was a problem hiding this comment.
this should be set on the raw data right?
Member
There was a problem hiding this comment.
or, create a custom user object with this prop.
atymic
reviewed
Aug 22, 2025
| protected function getTokenUrl() | ||
| { | ||
| // We must get the domain_prefix from the callback for the initial token request | ||
| $domainPrefix = request()->input('domain_prefix', $this->domainPrefix); |
Member
There was a problem hiding this comment.
Is it safe to get this from the url? example.com/# results in
curl 'https://example.com/#.retail.lightspeed.app/api/1.0/token'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.