Skip to content

wl_fixes protocol #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

wl_fixes protocol #726

wants to merge 4 commits into from

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented May 11, 2024

In addition to copying the protocol changes from https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/388, this required two things:

  • Modifies wayland-scanner to generate a WlRegistry type server-side. Instead of trying to make it produce a valid parse_request to handle the special case of the bind request, it just uses unimplemented!.
  • Adds a destroy_object method to destroy the object
    • Not sure if this is entirely correct as implemented.

See Smithay/smithay#1428 for server-side use of this.

@ids1024 ids1024 force-pushed the wl-fixes branch 7 times, most recently from 466e18c to e2731a9 Compare May 15, 2024 21:42
This was referenced May 15, 2024
Draft
Open
@ids1024
Copy link
Member Author

ids1024 commented May 16, 2024

I guess the server should also remove the registry from known_registries (looks like currently elements are only removed their when the client is gone.) Not sure if there's anything else that might need to be removed anywhere on registry destruction.

@ids1024
backend: Add destroy_object method
10b6ff0 
This is needed for implementing the `wl_fixes` protocol. It should also
make it possible to handle the requirement in
`zwlr_output_configuration_v1::destroy` to destroy the
`wlr_output_configuration_head`.
@ids1024
WIP update wayland.xml
2a6aea1 
This is now upstream; but waiting for release.
@ids1024
Generate Rust type binding wl_registry
40cf8c5 
Needed for `wl_fixes` bindings.
@dcz-self
Copy link

dcz-self commented Jul 5, 2025

This would unblock using the v10 wl_keyboard additions even if wl_fixes doesn't work correctly. I can offer some testing.

@dcz-self dcz-self mentioned this pull request Jul 5, 2025
Closed
@dcz-self
Copy link

dcz-self commented Jul 6, 2025

Version 1.24 has just been released. Is there any way I can help make this happen?

@ids1024
Copy link
Member Author

ids1024 commented Jul 7, 2025

The wayland.xml update can just be merged now. I guess then we'd want #727, which I think is correct but @elinorbgr wanted some tests for (which definitely is a good idea; but I haven't gotten around to doing it).

Then I have to remember if there was anything else still needed here... I did add a commit to update known_registries, so I think as far as I'm aware the changes here are good.

@dcz-self
Copy link

dcz-self commented Jul 9, 2025

I added some tests: #826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ids1024 @dcz-self