Skip to content

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Nov 21, 2024

Depends on Smithay/gbm.rs#25.

@ids1024 ids1024 force-pushed the gbm branch 2 times, most recently from 379cb54 to 7c9d52d Compare December 2, 2024 18:31
ids1024 added a commit to ids1024/gbm.rs that referenced this pull request Dec 2, 2024
I noticed this when updating
Smithay/smithay#1594.

Intesting that clippy doesn't warn about generics that aren't used
anywhere...

This is a breaking change.
ids1024 added a commit to ids1024/gbm.rs that referenced this pull request Dec 2, 2024
I noticed this when updating
Smithay/smithay#1594.

Interesting that clippy doesn't warn about generics that aren't used
anywhere...

This is a breaking change.
@Drakulix
Copy link
Member

Drakulix commented Dec 2, 2024

gbm-rs 0.17 is released.

Drakulix pushed a commit to Smithay/gbm.rs that referenced this pull request Dec 2, 2024
I noticed this when updating
Smithay/smithay#1594.

Interesting that clippy doesn't warn about generics that aren't used
anywhere...

This is a breaking change.
@ids1024
Copy link
Member Author

ids1024 commented Dec 2, 2024

I updated this, but I noticed there's still an unused generic: Smithay/gbm.rs#48.

It could be merged as is now, though it has to pass something explicitly as that generic. Annoying that clippy doesn't say anything about unused generics.

@Drakulix
Copy link
Member

Drakulix commented Dec 2, 2024

I updated this, but I noticed there's still an unused generic: Smithay/gbm.rs#48.

It could be merged as is now, though it has to pass something explicitly as that generic. Annoying that clippy doesn't say anything about unused generics.

v0.18 is inbound here https://github.com/Smithay/gbm.rs/actions/runs/12126008784

@ids1024
Copy link
Member Author

ids1024 commented Dec 2, 2024

It seems package 'gbm-sys' modified since '0.3.1' so new version should be published

@Drakulix
Copy link
Member

Drakulix commented Dec 3, 2024

It seems package 'gbm-sys' modified since '0.3.1' so new version should be published

https://github.com/Smithay/gbm.rs/actions/runs/12143920979/job/33862081369

@ids1024 ids1024 changed the title WIP Update to gbm.rs without DeviceDestroyedError Update gbm to 0.18 Dec 3, 2024
@ids1024 ids1024 marked this pull request as ready for review December 3, 2024 16:44
Eliminates `DeviceDestroyedError` and related error variants.
Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Drakulix Drakulix merged commit 0eba496 into Smithay:master Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants